-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation of singularity/rank-deficiency checks #924
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1930 1930
Lines 190055 190055
=======================================
Misses 190055 190055 ☔ View full report in Codecov by Sentry. |
Please note that I am still working on this PR, it is not ready for merge yet. Hence the draft status. |
This is now ready for review and merge. |
@langou If there are no objections, this is ready for merge when convenient. |
Description
This PR fixes and closes #918, by changing the relevant parts of the docs.
*TRTRS, *TBTRS and *TPTRS
A check is made to verify that A is nonsingular.
with the following:> 0: if INFO = i, the i-th diagonal element of A is zero,
with> 0: if INFO = i, the i-th diagonal element of A is exactly zero,
Callers of *TRTRS: *GELS, *GELST, *GETSLS, *GGLSE, *GGGLM
It is assumed that A has full rank.
with the following:> 0: if INFO = i, the i-th diagonal element of the triangular factor of A is zero
with> 0: if INFO = i, the i-th diagonal element of the triangular factor of A is exactly zero
RQ factorization of the pair (B, A) is singular
withRQ factorization of the pair (B, A) is exactly singular
QR factorization of the pair (A, B) is singular
withQR factorization of the pair (A, B) is exactly singular
Callers of *TBTRS:
Callers of *TPTRS:
Checklist