cmake: Use upstream helpers for the Config.cmake file #124
Conversation
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
5 times, most recently
from
aaa2c4f to
5618e4b
Compare
|
@LecrisUT I think my open ticket is waiting for this PR. |
|
Yes, but we should get #125 to be easier to review, at the very least for me to re-review myself 😅 |
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
from
5618e4b to
4446c06
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
from
4446c06 to
3af8f08
Compare
| @@ -0,0 +1,21 @@ | |||
| cmake_minimum_required(VERSION 3.17...4.0) | |||
There was a problem hiding this comment.
I don't remember why I set this one. But if anyone sees an issue with it just ping me. It might have been related to add_library(INTERFACE IMPORTED) or something else in the parts below.
There was a problem hiding this comment.
Does that mean 4.0 is the max? There is already a 4.1 release candiate.
There was a problem hiding this comment.
No, it means use policies up to version 4.0 as NEW. Read it as we have tested this part with "all cmakes" between <min>...<max>. The comment is about why I chose 3.17 as the minimum. For Config.cmake files, the minimum should be as low as possible.
First PR in the refactoring series. Use modern design for creating the
Config.cmakefile.Depends-on: #123, #125
Fixes #109
(Mostly, the targets created and exported are still not visible, but I want to address that in another PR that focuses on readability, which would be the last in the series)