Skip to content

Commit

Permalink
fix(create-efx): move template dependencies to peer dependencies (#474)
Browse files Browse the repository at this point in the history
* docs: add create-efx to package info section

* fix(create-efx): move core and elements to peer dependencies

* fix(create-efx): add generatejsx script to prepublish command

Co-authored-by: Sarin Udompanish <sarin.udompanish2@lseg.com>
  • Loading branch information
Sarin-Udompanish and Sarin Udompanish authored Sep 28, 2022
1 parent 3eabcc7 commit d8a0482
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Getting started and usage guide are available from this [documentation](https://
| [@refinitiv-ui/theme-compiler](https://github.com/Refinitiv/refinitiv-ui/tree/v6/packages/theme-compiler) | [![npm version](https://badgen.net/npm/v/@refinitiv-ui/theme-compiler)](https://www.npmjs.com/package/@refinitiv-ui/theme-compiler) | [![change log](https://badgen.net/badge/icon/changelog/grey?icon=git&label)](https://github.com/Refinitiv/refinitiv-ui/blob/v6/packages/theme-compiler/CHANGELOG.md) |
| [@refinitiv-ui/translate](https://github.com/Refinitiv/refinitiv-ui/tree/v6/packages/translate) | [![npm version](https://badgen.net/npm/v/@refinitiv-ui/translate)](https://www.npmjs.com/package/@refinitiv-ui/translate) | [![change log](https://badgen.net/badge/icon/changelog/grey?icon=git&label)](https://github.com/Refinitiv/refinitiv-ui/blob/v6/packages/translate/CHANGELOG.md) |
| [@refinitiv-ui/utils](https://github.com/Refinitiv/refinitiv-ui/tree/v6/packages/utils) | [![npm version](https://badgen.net/npm/v/@refinitiv-ui/utils)](https://www.npmjs.com/package/@refinitiv-ui/utils) | [![change log](https://badgen.net/badge/icon/changelog/grey?icon=git&label)](https://github.com/Refinitiv/refinitiv-ui/blob/v6/packages/utils/CHANGELOG.md) |
| [create-efx](https://github.com/Refinitiv/refinitiv-ui/tree/v6/packages/create-efx) | [![npm version](https://badgen.net/npm/v/create-efx)](https://www.npmjs.com/package/create-efx) | [![change log](https://badgen.net/badge/icon/changelog/grey?icon=git&label)](https://github.com/Refinitiv/refinitiv-ui/blob/v6/packages/create-efx/CHANGELOG.md) |


# License Information
Expand Down Expand Up @@ -64,6 +65,7 @@ Element Framework is using monorepo. This repository has elements, supporting mo

* `packages/configurations` - Configuration file for element development e.g. eslint, typescript
* `packages/core` - Core module of element e.g. base classes, element registration
* `packages/create-efx` - Initializer for creating a new EFX elements
* `packages/demo-block` - Use in demo page of each element to demonstrate element's features
* `packages/elemental-theme` - Base theme to extend to design system theme e.g. Halo Theme
* `packages/elements` - All elements in Element Framework
Expand Down
12 changes: 6 additions & 6 deletions packages/create-efx/template/package.json.template
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,14 @@
"test:watch": "wtr --node-resolve --watch",
"test:snapshots": "wtr --node-resolve --update-snapshots",
"generate:jsx": "node ./scripts/jsx/jsxdts-generator.js",
"prepublishOnly": "npm run build"
"prepublishOnly": "npm run build && npm run generate:jsx"
},
"dependencies": {
"tslib": "^2.4.0",
"@refinitiv-ui/core": "^6.0.5",
"@refinitiv-ui/elements": "^6.1.1"
"tslib": "^2.4.0"
},
"devDependencies": {
"@refinitiv-ui/configurations": "^6.0.4",
"@refinitiv-ui/demo-block": "^6.0.6",
"@refinitiv-ui/halo-theme": "^6.1.4",
"@refinitiv-ui/solar-theme": "^6.0.5",
"@refinitiv-ui/test-helpers": "^6.0.4",
"@refinitiv-ui/theme-compiler": "^6.0.4",
"@web/dev-server-esbuild": "^0.3.2",
Expand All @@ -41,5 +37,9 @@
"fast-glob": "^3.2.12",
"typescript": "^4.8.3",
"vite": "^3.1.0"
},
"peerDependencies": {
"@refinitiv-ui/core": "^6.0.7",
"@refinitiv-ui/elements": "^6.1.1"
}
}

0 comments on commit d8a0482

Please sign in to comment.