Support old uinput interface #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to use UI_GET_VERSION ioctl to check whether to fall back to old uinput interface (for kernels < 4.5) as described in [1] and [2]. [1]: kernel.org/doc/html/latest/input/uinput.html#uinput-old-interface [2]: github.com/torvalds/linux/blob/master/include/uapi/linux/uinput.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes ydotool work on very old kernels (older than 4.5, which was released in March 2016), where it previously did not work because the
UI_DEV_SETUPioctlis not available.Try to use
UI_GET_VERSIONioctl(introduced in kernel 3.17, released in October 2014) to check whether to fall back to old uinput interface as described in https://kernel.org/doc/html/latest/input/uinput.html#uinput-old-interface and https://github.com/torvalds/linux/blob/master/include/uapi/linux/uinput.h#L89.If
UI_GET_VERSIONfails, also try to use the old interface.Tested on 6.11.3 and 4.4.153 (where it doesn't work without this patch).