Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples (demo scripts and notebooks) #113

Merged
merged 21 commits into from
Feb 13, 2024
Merged

Fix examples (demo scripts and notebooks) #113

merged 21 commits into from
Feb 13, 2024

Conversation

thomasgaudelet
Copy link
Contributor

What is the goal of this PR?

The objective of this PR is to update examples to ensure they can run.

What are the changes implemented in this PR?

  • One of the key issue was with removed support for Subset datasets in previous release of pyrelational.
  • examples/utils/ moved to examples/demo/utils/

@thomasgaudelet thomasgaudelet marked this pull request as ready for review February 7, 2024 17:05
paulmorio
paulmorio previously approved these changes Feb 7, 2024
Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just notice that some changes are also the same in #112 will there be any merge-conflicts?

@thomasgaudelet
Copy link
Contributor Author

Looks good to me, just notice that some changes are also the same in #112 will there be any merge-conflicts?

@paulmorio that is because I worked from the other PR's branch to work on this. The previous PR must be merged before this one.

paulmorio
paulmorio previously approved these changes Feb 12, 2024
Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasgaudelet thomasgaudelet merged commit 7aa8c04 into main Feb 13, 2024
5 checks passed
@thomasgaudelet thomasgaudelet deleted the fix-examples branch February 13, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants