Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local environment for pre-commit #146

Merged
merged 13 commits into from
Apr 10, 2024
Merged

Conversation

thomasgaudelet
Copy link
Contributor

What is the goal of this PR?

This PR changes the precommit yaml configuration file such that it uses the local environment instead of reinstalling an environment. This has the added benefit of avoiding multiple version definition.

What are the changes implemented in this PR?

Modify configuration to use local env.

@thomasgaudelet thomasgaudelet requested review from a-pouplin, paulmorio and alicerdv and removed request for a-pouplin April 8, 2024 14:38
paulmorio
paulmorio previously approved these changes Apr 8, 2024
Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for this.

a-pouplin
a-pouplin previously approved these changes Apr 9, 2024
@thomasgaudelet thomasgaudelet dismissed stale reviews from a-pouplin and paulmorio via 98a4fdc April 9, 2024 16:07
@thomasgaudelet thomasgaudelet merged commit 4fd1bc5 into main Apr 10, 2024
5 checks passed
@thomasgaudelet thomasgaudelet deleted the precommit-with-local-env branch April 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants