Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffling labelled set #18

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Shuffling labelled set #18

merged 5 commits into from
Sep 9, 2022

Conversation

ojpb
Copy link
Contributor

@ojpb ojpb commented Sep 9, 2022

Changing default shuffling to true, and only specifying shuffling for labelled data loader.

Setting the default to true makes more sense for how train sets are used.
Shuffling the unlabelled loaders would lead to the wrong samples from being selected. So this removes that bug.

@ojpb ojpb requested a review from thomasgaudelet September 9, 2022 12:13
Copy link
Contributor

@thomasgaudelet thomasgaudelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@ojpb ojpb merged commit b478b4f into RelationRx:main Sep 9, 2022
@ojpb ojpb deleted the data-shuffling branch September 9, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants