Changing resolution of train/test/validation indices in datamanager. And make data manager mypy compliant #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicerdv
changed the title
thomasgaudelet
previously approved these changes
Nov 22, 2022
a-pouplin
reviewed
Nov 22, 2022
Good point. I will add that |
I've now added an error when test indices are none after train/test are made :) (there was already an error for train indices being none) |
a-pouplin
previously approved these changes
Nov 23, 2022
a-pouplin
approved these changes
Nov 23, 2022
thomasgaudelet
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the resolution of the train/test/validation indices in the datamanager. An image has been added to the doc string to explain this. Tests for the resolution of indices for all cases have also been added.