-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor unit tests and add some #55
Conversation
remove mention to "generic" in file names rework strategy/pipeline for easy testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! I like how neat the tests look :)
pyrelational/strategies/regression/abstract_regression_strategy.py
Outdated
Show resolved
Hide resolved
…ddress PR comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for changing the module names from their "generic-" prefixes. I think the new names sound better. Also thank you for the new tests in the oracle and pipeline as Alice says they are very clean with the new packages.
I am happy with the changes to using __call__
in strategies with the filtering step there. I have made some other small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks for all the work, let me know when you merge so I will update the examples
What is the goal of this PR?
This PR goal is to improve unit tests. Some changes were required in other files to enable this.
What are the changes implemented in this PR?