Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor unit tests and add some #55

Merged
merged 9 commits into from
Jan 13, 2023
Merged

Refactor unit tests and add some #55

merged 9 commits into from
Jan 13, 2023

Conversation

thomasgaudelet
Copy link
Contributor

What is the goal of this PR?

This PR goal is to improve unit tests. Some changes were required in other files to enable this.

What are the changes implemented in this PR?

  • add unit tests for pipeline, oracle and strategies
  • remove mention to "generic" in file names
  • rework strategy/pipeline for easy testing. specifically, the strategy itself calls the kwargs filtering instead of the pipeline. This reduces the number of testing function required, or the complexity of the arguments, as it allows for laxer inputs to the active_learning_step function.

remove mention to "generic" in file names
rework strategy/pipeline for easy testing
@thomasgaudelet thomasgaudelet changed the title Refefactor unit tests and add some Refactor unit tests and add some Jan 9, 2023
@paulmorio paulmorio mentioned this pull request Jan 9, 2023
Copy link
Contributor

@alicerdv alicerdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I like how neat the tests look :)

paulmorio
paulmorio previously approved these changes Jan 10, 2023
Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing the module names from their "generic-" prefixes. I think the new names sound better. Also thank you for the new tests in the oracle and pipeline as Alice says they are very clean with the new packages.

I am happy with the changes to using __call__ in strategies with the filtering step there. I have made some other small comments.

Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for all the work, let me know when you merge so I will update the examples

@thomasgaudelet thomasgaudelet merged commit 88c8f6d into main Jan 13, 2023
@thomasgaudelet thomasgaudelet deleted the add-unit-tests branch January 13, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants