Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regression_greedy_score name to regression_mean_prediction #82

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

alicerdv
Copy link
Contributor

@alicerdv alicerdv commented Feb 7, 2023

What is the goal of this PR?

Change the name of regression_greedy_score to regression_mean_prediction for consistency with the change from GreedyStrategy to MeanPredictionStrategy

What are the changes implemented in this PR?

Change name from regression_greedy_score -> regression_mean_prediction and changes to the name where it is used

@alicerdv alicerdv assigned a-pouplin and unassigned a-pouplin Feb 7, 2023
@alicerdv alicerdv requested a review from a-pouplin February 7, 2023 11:21
Copy link
Collaborator

@a-pouplin a-pouplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@alicerdv alicerdv merged commit b74b3c0 into RelationRx:main Feb 7, 2023
@alicerdv alicerdv deleted the change_greedy_score branch February 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants