Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods #85

Merged
merged 13 commits into from
Feb 9, 2023
Merged

Rename methods #85

merged 13 commits into from
Feb 9, 2023

Conversation

a-pouplin
Copy link
Collaborator

Simplify method names

What is the goal of this PR?

The goal is to rename some methods, as raised by issue #56.

What are the changes implemented in this PR?

The methods are renamed the following way:

DataManager

  • percentage_labelled -> get_percentage_labelled

Pipeline

  • theoretical_performance -> compute_theoretical_performance
  • current_performance -> compute_current_performance
  • active_learning_step -> step
  • active_learning_update -> query
  • full_active_learning_run -> run
  • performance_history -> summary

Strategy

  • active_learning_step -> suggest

--
Note: I didn't modify the method create_loader (from DataManager), which was aimed to be private. :)

Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating all of this and the extra files (Readme + examples)!

I think you can go ahead and actually make create_loader() private by renaming it to _create_loader()

Otherwise LGTM

Copy link
Contributor

@alicerdv alicerdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Collaborator

@paulmorio paulmorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@thomasgaudelet thomasgaudelet merged commit 6302148 into RelationRx:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants