-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename methods #85
Rename methods #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating all of this and the extra files (Readme + examples)!
I think you can go ahead and actually make create_loader()
private by renaming it to _create_loader()
Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
Simplify method names
What is the goal of this PR?
The goal is to rename some methods, as raised by issue #56.
What are the changes implemented in this PR?
The methods are renamed the following way:
DataManager
get_percentage_labelled
Pipeline
compute_theoretical_performance
compute_current_performance
step
query
run
summary
Strategy
suggest
--
Note: I didn't modify the method
create_loader
(from DataManager), which was aimed to be private. :)