Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make testset and testcase support for loops. #10

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Make testset and testcase support for loops. #10

merged 1 commit into from
Feb 12, 2021

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Feb 9, 2021

No description provided.

@maleadt
Copy link
Contributor Author

maleadt commented Feb 9, 2021

What doesn't work: continue in @testcase; using return works around it. Not easy to work around, I think.

@mdashti mdashti requested review from mdashti, a user and Sacha0 February 9, 2021 17:45
@mdashti mdashti added the enhancement New feature or request label Feb 9, 2021
@mdashti
Copy link
Contributor

mdashti commented Feb 10, 2021 •
edited
Loading

Thanks @maleadt! Awesome improvement! Was on my TODO-list for a while. Really appreciate it. Will review it ASAP.

mdashti
mdashti approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@mdashti mdashti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maleadt. LGTM.

@mdashti mdashti merged commit eb633ba into RelationalAI-oss:master Feb 12, 2021
@maleadt maleadt deleted the tb/for_loop branch February 12, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdashti mdashti mdashti approved these changes

@Sacha0 Sacha0 Awaiting requested review from Sacha0

Assignees

@maleadt maleadt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maleadt @mdashti