Switch Julia bindings to the new async API based on RustyObjectStore #3
Conversation
|
|
||
| [deps] | ||
| Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45" | ||
| BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf" |
There was a problem hiding this comment.
Ideally we switch our example to a test, and make this a test dependency.
| free_table(state.table) | ||
| catch e | ||
| # Log but don't throw in finalizer | ||
| # TODO: should we keep this log or throw? |
There was a problem hiding this comment.
Let's figure this out. Will it show with safelogging?
There was a problem hiding this comment.
I am not sure tbh. The problem is I guess we cannot catch that exception in raicode no?
There was a problem hiding this comment.
Yeah, not sure what ahppens with exceptions in finalizer, probably nothing, or might crash the process? But also not sure if we can safe log them, given that we don't have access to safe logging. Can we ask somebody what's the best practice here?
|
Let's just also add a short description here, maybe link iceberg_rust_ffi PR too |
|
The tests are failing, not sure if this would block the merge, but we should fix them |
2 participants
Adds support for the async interface provided by iceberg_rust_ffi in RelationalAI/iceberg_rust_ffi#3