Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on return type #63

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Check on return type #63

wants to merge 6 commits into from

Conversation

bergel
Copy link
Collaborator

@bergel bergel commented Aug 5, 2024

WIP

Copy link

github-actions bot commented Aug 16, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-08-16T14:32:21.742)

  • Line 51, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 199, column 12: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 279, column 21: Use custom exception instead of the generic error(). raicode/src/interface.jl
  • Line 465, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/interface.jl
  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 272, column 5: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 315, column 13: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
  • Line 347, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 401, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 404, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 405, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 445, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 542, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 555, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 564, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
    🚨In total, 15 rule violations and 0 PR reviewer recommendation are found over 3 Julia files🚨

@bergel bergel marked this pull request as draft August 20, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant