Removing legacy StaticLint

Manifest.toml

@@ -2,14 +2,7 @@
 
 julia_version = "1.10.2"
 manifest_format = "2.0"
-project_hash = "255338e3f9e4c058e9a5fae9b019df749db3086a"
-
-[[deps.ArgTools]]
-uuid = "0dad84c5-d112-42e6-8d28-ef12dabb789f"
-version = "1.1.1"
-
-[[deps.Artifacts]]
-uuid = "56f22d72-fd6d-98f1-02f0-08ddc0907c33"
+project_hash = "64d1be42d85e48d8d22a77d412761d83485cc341"
 
 [[deps.Base64]]
 uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
@@ -24,14 +17,6 @@ version = "3.4.3"
 deps = ["Printf"]
 uuid = "ade2ca70-3891-5945-98fb-dc099432e06a"
 
-[[deps.Downloads]]
-deps = ["ArgTools", "FileWatching", "LibCURL", "NetworkOptions"]
-uuid = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
-version = "1.6.0"
-
-[[deps.FileWatching]]
-uuid = "7b1f6079-737a-58dc-b8bc-7a2ca5c1b5ee"
-
 [[deps.InteractiveUtils]]
 deps = ["Markdown"]
 uuid = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
@@ -48,67 +33,19 @@ version = "1.14.0"
     [deps.JSON3.weakdeps]
     ArrowTypes = "31f734f8-188a-4ce0-8406-c8a06bd891cd"
 
-[[deps.LibCURL]]
-deps = ["LibCURL_jll", "MozillaCACerts_jll"]
-uuid = "b27032c2-a3e7-50c8-80cd-2d36dbcbfd21"
-version = "0.6.4"
-
-[[deps.LibCURL_jll]]
-deps = ["Artifacts", "LibSSH2_jll", "Libdl", "MbedTLS_jll", "Zlib_jll", "nghttp2_jll"]
-uuid = "deac9b47-8bc7-5906-a0fe-35ac56dc84c0"
-version = "8.4.0+0"
-
-[[deps.LibGit2]]
-deps = ["Base64", "LibGit2_jll", "NetworkOptions", "Printf", "SHA"]
-uuid = "76f85450-5226-5b5a-8eaa-529ad045b433"
-
-[[deps.LibGit2_jll]]
-deps = ["Artifacts", "LibSSH2_jll", "Libdl", "MbedTLS_jll"]
-uuid = "e37daf67-58a4-590a-8e99-b0245dd2ffc5"
-version = "1.6.4+0"
-
-[[deps.LibSSH2_jll]]
-deps = ["Artifacts", "Libdl", "MbedTLS_jll"]
-uuid = "29816b5a-b9ab-546f-933c-edad1886dfa8"
-version = "1.11.0+1"
-
-[[deps.Libdl]]
-uuid = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
-
-[[deps.Logging]]
-uuid = "56ddb016-857b-54e1-b83d-db4d58db5568"
-
 [[deps.Markdown]]
 deps = ["Base64"]
 uuid = "d6f4376e-aef5-505a-96c1-9c027394607a"
 
-[[deps.MbedTLS_jll]]
-deps = ["Artifacts", "Libdl"]
-uuid = "c8ffd9c3-330d-5841-b78e-0817d7145fa1"
-version = "2.28.2+1"
-
 [[deps.Mmap]]
 uuid = "a63ad114-7e13-5084-954f-fe012c677804"
 
-[[deps.MozillaCACerts_jll]]
-uuid = "14a3606d-f60d-562e-9121-12d972cd8159"
-version = "2023.1.10"
-
-[[deps.NetworkOptions]]
-uuid = "ca575930-c2e3-43a9-ace4-1e988b2c1908"
-version = "1.2.0"
-
 [[deps.Parsers]]
 deps = ["Dates", "PrecompileTools", "UUIDs"]
 git-tree-sha1 = "8489905bcdbcfac64d1daa51ca07c0d8f0283821"
 uuid = "69de0a69-1ddd-5017-9359-2bf0b02dc9f0"
 version = "2.8.1"
 
-[[deps.Pkg]]
-deps = ["Artifacts", "Dates", "Downloads", "FileWatching", "LibGit2", "Libdl", "Logging", "Markdown", "Printf", "REPL", "Random", "SHA", "Serialization", "TOML", "Tar", "UUIDs", "p7zip_jll"]
-uuid = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
-version = "1.10.0"
-
 [[deps.PrecompileTools]]
 deps = ["Preferences"]
 git-tree-sha1 = "5aa36f7049a63a1528fe8f7c3f2113413ffd4e1f"
@@ -125,10 +62,6 @@ version = "1.4.3"
 deps = ["Unicode"]
 uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 
-[[deps.REPL]]
-deps = ["InteractiveUtils", "Markdown", "Sockets", "Unicode"]
-uuid = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb"
-
 [[deps.Random]]
 deps = ["SHA"]
 uuid = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
@@ -140,31 +73,17 @@ version = "0.7.0"
 [[deps.Serialization]]
 uuid = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 
-[[deps.Sockets]]
-uuid = "6462fe0b-24de-5631-8697-dd941f90decc"
-
 [[deps.StructTypes]]
 deps = ["Dates", "UUIDs"]
 git-tree-sha1 = "ca4bccb03acf9faaf4137a9abc1881ed1841aa70"
 uuid = "856f2bd8-1eba-4b0a-8007-ebc267875bd4"
 version = "1.10.0"
 
-[[deps.SymbolServer]]
-deps = ["InteractiveUtils", "LibGit2", "Markdown", "Pkg", "REPL", "SHA", "Serialization", "Sockets", "UUIDs"]
-git-tree-sha1 = "adcc6a2335e5448adc05939f67d382fb8d17a367"
-uuid = "cf896787-08d5-524d-9de7-132aaa0cb996"
-version = "7.4.0"
-
 [[deps.TOML]]
 deps = ["Dates"]
 uuid = "fa267f1f-6049-4f14-aa54-33bafae1ed76"
 version = "1.0.3"
 
-[[deps.Tar]]
-deps = ["ArgTools", "SHA"]
-uuid = "a4e569a6-e804-4fa4-b0f3-eef7a1d5b13e"
-version = "1.10.0"
-
 [[deps.Tokenize]]
 git-tree-sha1 = "468b4685af4abe0e9fd4d7bf495a6554a6276e75"
 uuid = "0796e94c-ce3b-5d07-9a54-7f471281c624"
@@ -176,18 +95,3 @@ uuid = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 
 [[deps.Unicode]]
 uuid = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"
-
-[[deps.Zlib_jll]]
-deps = ["Libdl"]
-uuid = "83775a58-1f1d-513f-b197-d71354ab007a"
-version = "1.2.13+1"
-
-[[deps.nghttp2_jll]]
-deps = ["Artifacts", "Libdl"]
-uuid = "8e850ede-7688-5339-a07c-302acd2aaf8d"
-version = "1.52.0+1"
-
-[[deps.p7zip_jll]]
-deps = ["Artifacts", "Libdl"]
-uuid = "3f19e933-33d8-53b3-aaab-bd5110c3b7a0"
-version = "17.4.0+2"

Project.toml

@@ -8,11 +8,9 @@ Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
 JSON3 = "0f8b85d8-7281-11e9-16c2-39a750bddbf1"
 Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
-SymbolServer = "cf896787-08d5-524d-9de7-132aaa0cb996"
 
 [compat]
 CSTParser = "3.3"
-SymbolServer = "5.1.1, 6.0, 7.0"
 julia = "1"
 
 [extras]

scripts/run_lint_locally.sh

@@ -1,50 +1,39 @@
 #!/bin/bash
 
-# If file exist, typically from a previous run, then we remove it
-if [ -f /tmp/files_to_run_lint.txt ]; then
-   rm /tmp/files_to_run_lint.txt
-fi
-
-# If the file containing result of lint exist, then we remove it
-if [ -f /tmp/result_lint.txt ]; then
-   rm /tmp/result_lint.txt
-fi
+# temporary file containing all the files on which lint has to run.
+FILES_TO_RUN=$(mktemp)
 
 # If no argument is provided, then we simply use the files staged
 if [[ $# -eq 0 ]] ; then
     echo 'No argument provided, running on staged files'
     FILES_LOCALLY_ADDED=`git status --porcelain | awk 'match($1, "A"){print $2}'`
     FILES_LOCALLY_MODIFIED=`git status --porcelain | awk 'match($1, "M"){print $2}'`
-    echo ${FILES_LOCALLY_ADDED} > /tmp/files_to_run_lint.txt
-    echo ${FILES_LOCALLY_MODIFIED} >> /tmp/files_to_run_lint.txt
+    echo ${FILES_LOCALLY_ADDED} > $FILES_TO_RUN
+    echo ${FILES_LOCALLY_MODIFIED} >> $FILES_TO_RUN
 else
     # If some files are provided, then we use these
-    echo $@ >> /tmp/files_to_run_lint.txt
+    echo $@ >> $FILES_TO_RUN
     # echo "RUNNING LINT ON: "
-    # cat /tmp/files_to_run_lint.txt
+    # cat "$FILES_TO_RUN"
     # echo "---"
 fi
 
 # Running StaticLint
 echo "FULLNAME SCRIPT" $0
 STATICLINTPATH=$(dirname $0)/..
 echo "STATICLINT PATH=" $STATICLINTPATH
-# cd $STATICLINTPATH
-# ls
-echo "CURRENT PATH=" $PWD
-
-echo "Julia Registry updating and instantiating..."
-cd $STATICLINTPATH
-julia --project=$STATICLINTPATH -e "
-  import Pkg ; Pkg.Registry.update() ; Pkg.instantiate() ; Pkg.build()
-"
-cd -
+RAICODE_PATH=$PWD
+echo "CURRENT PATH=" $RAICODE_PATH
+echo "FILES_TO_RUN=" $FILES_TO_RUN
 
 echo "About to run StaticLint.jl..."
 julia --project=$STATICLINTPATH -e "
+  import Pkg
+  Pkg.instantiate()
+
   using StaticLint
   result = StaticLint.LintResult()
-  all_files_tmp=split(open(io->read(io, String), \"/tmp/files_to_run_lint.txt\", \"r\"))
+  all_files_tmp=split(open(io->read(io, String), \"$FILES_TO_RUN\", \"r\"))
   # convert substring into string
   all_files=map(string, all_files_tmp)
   # filter to existing Julia files only