Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for module bindings crash #158

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Commits on Jun 5, 2024

  1. Add boundscheck in bindingkey_eq to avoid OOB access due to data race (

    …JuliaLang#54671)
    
    The race here is that svec might be replaced and a new binding
    introduced into the keyset while we hold a reference to the old svec,
    which led to a OOB access on the svec with the index a binding
    introduced at the same time. This now introduces a bounds check which
    will force taking the lock if we fail the lookup i.e we had a data race.
    
    Fixes JuliaLang#54285
    
    ---------
    
    Co-authored-by: Jameson Nash <vtjnash@gmail.com>
    2 people authored and kpamnany committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    721ed37 View commit details
    Browse the repository at this point in the history