Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: all task (wall-clock) profiler #177

Closed
wants to merge 11 commits into from
Closed

WIP: all task (wall-clock) profiler #177

wants to merge 11 commits into from

Conversation

nickrobinson251
Copy link
Member

@nickrobinson251 nickrobinson251 commented Sep 5, 2024 •
edited
Loading

PR Description

What does this PR do?
WIP on RAI-14413

Misc todos:

  • rename globals to make "profiling" clear (e.g. running -> profile_running, bt_size_max -> prof_bt_size_max)
  • what to do about dropped samples?
    • put placeholder / dud value (rather than dropping samples)?
    • return true sample rate (given we dropped samples)?
    • resample? No, probably too slow or risks biasing the sample
  • what's up with sticky tasks? these tasks always have a thread id set, so we're going to stop the thread it's "stuck" to... but we still need to now whether the thread was actually running the sticky task or not, to know what "context" to pass in
    • check if the ptls->current_task is the sticky task we're trying to profile? if is is, fine. If not, what? How do we collect the backtrace?

Checklist

Requirements for merging:

  • I have opened an issue or PR upstream on JuliaLang/julia: <link to JuliaLang/julia>
  • I have removed the port-to-* labels that don't apply.
  • I have opened a PR on raicode to test these changes:

@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds labels Sep 5, 2024
nickrobinson251 pushed a commit that referenced this pull request Sep 11, 2024
@DilumAluthgeBot @DilumAluthge
🤖 [master] Bump the Tar stdlib from 81888a3 to 1114260 (JuliaLang#54670)
ef19235 
Stdlib: Tar
URL: https://github.com/JuliaIO/Tar.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 81888a3
New commit: 1114260
Julia version: 1.12.0-DEV
Tar version: 1.10.0(Does not match)
Bump invoked by: @StefanKarpinski
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaIO/Tar.jl@81888a3...1114260

```
$ git log --oneline 81888a3..1114260
1114260 Accept other string types for all string arguments (fix #179) (#180)
a2e39d6 Bump julia-actions/cache from 1 to 2 (#178)
152d12e Bump julia-actions/setup-julia from 1 to 2 (#177)
5012536 Fix Codecov (#176)
9b5460b Add `public` declarations using `eval` (#175)
4e9d73a Add docstring for Tar module (#173)
38a4bf4 Bump codecov/codecov-action from 3 to 4 (#172)
166deb3 [CI] Switch to `julia-actions/cache` (#171)
d0085d8 Hardcode doc edit backlink (#164)
7e83ed7 [NFC] fix some wonky formatting (#168)
6269b5b Bump actions/checkout from 3 to 4 (#163)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
@d-netto d-netto mentioned this pull request Sep 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-to-master This change should apply to all future Julia builds port-to-v1.10 This change should apply to Julia v1.10 builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrobinson251 @d-netto