Skip to content

Don't use macros inside logmsg_code #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2025
Merged

Don't use macros inside logmsg_code #250

merged 1 commit into from
Aug 21, 2025

Conversation

Drvi
Copy link
Member

@Drvi Drvi commented Aug 19, 2025 •
edited
Loading

A workaround for RAI-40366 which manually gensyms the two names that macro hygiene didn't work for when called from Match.@match

Checklist

Requirements for merging:

@Drvi Drvi marked this pull request as draft August 19, 2025 15:54
@Drvi Drvi marked this pull request as ready for review August 19, 2025 17:35
@DelveCI DelveCI force-pushed the v1.12.0-DEV+RAI branch 2 times, most recently from b253782 to f49a8a6 Compare August 21, 2025 00:31
@Drvi Drvi force-pushed the td-1-12-logging-definedness branch 2 times, most recently from 2f7d59b to d9ba7d1 Compare August 21, 2025 17:54
@Drvi Drvi requested review from nickrobinson251 and NHDaly August 21, 2025 18:00
nickrobinson251
nickrobinson251 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we like the commits to have the RAI: prefix when they're RAI-specific (not simple backports)

Otherwise LGTM! thanks!

@Drvi Drvi force-pushed the td-1-12-logging-definedness branch from d9ba7d1 to 37255f9 Compare August 21, 2025 18:40
@Drvi Drvi merged commit 44cfff2 into v1.12.0-DEV+RAI Aug 21, 2025
3 checks passed
@Drvi Drvi deleted the td-1-12-logging-definedness branch August 21, 2025 18:41
DelveCI pushed a commit that referenced this pull request Aug 22, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
aff650b
DelveCI pushed a commit that referenced this pull request Aug 26, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
f64b74f
DelveCI pushed a commit that referenced this pull request Aug 27, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
dec3856
kpamnany pushed a commit that referenced this pull request Aug 29, 2025
@Drvi @kpamnany
RAI: Don't use macros inside logmsg_code (#250)
7d9fb99
kpamnany pushed a commit that referenced this pull request Aug 29, 2025
@Drvi @kpamnany
RAI: Don't use macros inside logmsg_code (#250)
ce55bae
DelveCI pushed a commit that referenced this pull request Sep 2, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
35b0f08
DelveCI pushed a commit that referenced this pull request Sep 2, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
9c3bd8a
DelveCI pushed a commit that referenced this pull request Sep 3, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
5edeae9
Drvi added a commit that referenced this pull request Sep 4, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
e376ce2
DelveCI pushed a commit that referenced this pull request Sep 6, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
c820cee
DelveCI pushed a commit that referenced this pull request Sep 7, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
9a42d18
d-netto pushed a commit that referenced this pull request Sep 15, 2025
@Drvi @d-netto
RAI: Don't use macros inside logmsg_code (#250)
50e7cc5
d-netto pushed a commit that referenced this pull request Sep 19, 2025
@Drvi
RAI: Don't use macros inside logmsg_code (#250)
94685e1
nickrobinson251 added a commit that referenced this pull request Oct 8, 2025
@nickrobinson251
Revert "RAI: Don't use macros inside logmsg_code (#250)"
c7325c2 
This reverts commit 9a42d18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 approved these changes

@NHDaly NHDaly Awaiting requested review from NHDaly

Assignees
No one assigned
Labels
port-to-master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drvi @nickrobinson251