Backport support for async backtraces #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpamnany
force-pushed
the
kp-backport-51430
branch
from
99def4c to
145079c
Compare
|
I don't know how to review this 😛 How have you tested that this works? given it is merged upstream, I'd be happy to approve so long as you've tested it works |
|
Yeah, glad you asked. It does work fine on upstream |
|
Fixed the build issue, but then found that this actually crashes if you run with multiple threads. Upstream fix is JuliaLang#51471. |
kpamnany
force-pushed
the
kp-backport-51430
branch
from
3a806c6 to
4278e6d
Compare
As that PR is not in 1.9.
In `jl_print_task_backtraces()`. Follow-on to JuliaLang#51430.
kpamnany
force-pushed
the
kp-backport-51430
branch
from
4278e6d to
5959ae2
Compare
|
Fixed and checked that it seems to work, even with multiple threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Backport JuliaLang#51430.
Checklist
Requirements for merging:
port-to-*labels that don't apply.