-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move ramstk_measurement to sub-package #997
refactor: move ramstk_measurement to sub-package #997
Conversation
Codecov Report
@@ Coverage Diff @@
## master #997 +/- ##
==========================================
- Coverage 94.91% 94.86% -0.05%
==========================================
Files 170 172 +2
Lines 5249 5260 +11
Branches 502 502
==========================================
+ Hits 4982 4990 +8
- Misses 232 235 +3
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.41%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To move tables in common database to sub-packages under commondb.
Describe how this was implemented.
Created measurement sub-package. Moved ramstk_measurement.py to sub-package as record.py. Created table.py. Updated ramstk_measurement test suite.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Partially implements #846
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
decorating the code block. These # ISSUE: comments are automatically
converted to issues on successful merge. Alternatively, you can manually
raise an issue for each problem area you identify.