Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION tag ignored in VorbisComment #200

Closed
ghost opened this issue May 29, 2017 · 0 comments
Closed

VERSION tag ignored in VorbisComment #200

ghost opened this issue May 29, 2017 · 0 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented May 29, 2017

Expected behavior

For tracks with a subtitle either SUBTITLE (ID3) or VERSION (VorbisComment) is used.

Actual behavior

For ID3 (.mp3) it works with the SUBTITLE tag, but for VorbisComment (.flac, .ogg) the VERSION tag is ignored.

Steps to reproduce the behavior

  1. Tag an audio file (.flac or .ogg) with a VERSION tag, for example “12 Inch Version”.
  2. Scan for new audio files.
  3. Share the file and look at the sharing page.
  4. There is no "Subtitle" info displayed in the Share Player.

Possible solution (optional)

Detect the VERSION tag correctly in fLaC and OggS.

Server configuration

Audio Player version: (see /settings/apps)
2.0.1

@ghost ghost added this to the 2.0.2 milestone May 29, 2017
@ghost ghost assigned Rello May 29, 2017
Rello added a commit that referenced this issue May 30, 2017
ghost pushed a commit that referenced this issue May 30, 2017
@ghost ghost closed this as completed Jun 9, 2017
@ghost ghost removed the pending release label Jun 9, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant