Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS issue - X looks clipped off #247

Closed
AmonBune opened this issue Oct 22, 2017 · 2 comments
Closed

CSS issue - X looks clipped off #247

AmonBune opened this issue Oct 22, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@AmonBune
Copy link

Expected behavior

The close X on the rescan popup looks nice.

Actual behavior

The close X on the rescan popup is clipped off.

Steps to reproduce the behavior

Press the rescan button and look at the X.

Possible solution

Remove these 2 tags from the .ui-button-icon-only / .ui-icon CSS:
left: 50%;
margin-left: -8px;

This is the original:
original

This is the corrected version by me:
corrected

Server configuration

Nextcloud/ownCloud version:
12.0.3

Audio Player version:
2.1.0

Where did you install Audio Player from:
Nextcloud apps

Are you using external storage:
No

Are you using encryption: yes/no
No

Client configuration

Operating system:
Ubuntu 17.10, Windows 10

Browser:
Firefox

@ghost
Copy link

ghost commented Oct 22, 2017

The same with the reset popup. ;-)

@ghost ghost assigned Rello Oct 22, 2017
@ghost ghost added bug design labels Oct 22, 2017
@ghost ghost added this to the 2.2.0 milestone Oct 22, 2017
@ghost ghost added the investigation label Oct 22, 2017
@Rello
Copy link
Owner

Rello commented Oct 28, 2017

hello,
thank you for the input!

I will search for the details. Issue is, that this is a core css which can not be changed by audio player.
But we will find a solution...

Rello added a commit that referenced this issue Oct 30, 2017
move from .dialog to .ocdialog for better integration

Signed-off-by: Rello <github@scherello.de>
@Rello Rello added testing and removed in progress labels Oct 30, 2017
ghost pushed a commit that referenced this issue Oct 30, 2017
@ghost ghost removed the pending release label Nov 17, 2017
@ghost ghost closed this as completed Nov 17, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants