Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud 14 compliance #266

Closed
MorrisJobke opened this issue Jan 14, 2018 · 1 comment
Closed

Nextcloud 14 compliance #266

MorrisJobke opened this issue Jan 14, 2018 · 1 comment
Assignees
Milestone

Comments

@MorrisJobke
Copy link

We are dropping some constants that are deprecated for 3 years now. One of them is still used in here: https://github.com/rello/audioplayer/blob/fbf532377a07a205163e27248ad14da831b2121b/lib/Controller/EditorController.php#L73

PR: nextcloud/server#7844

@Rello Please update your code to run it on NC 14+ too.

Please also have a look at nextcloud/server#7827 for other dropped methods or use the app:code-check to highlight deprecated methods in the current code.

@Rello Rello self-assigned this Jan 14, 2018
@Rello
Copy link
Owner

Rello commented Jan 14, 2018

Hallo @MorrisJobke ,

thank you for the hint!
interestingly, I got the same warning yesterday after scruitinizer was switched to the new validator.
I will check again and we will include this in the next release

@ghost ghost added the nextcloud label Jan 14, 2018
Rello added a commit that referenced this issue Jan 16, 2018
@Rello Rello added this to the 2.2.3 milestone Jan 16, 2018
Rello added a commit that referenced this issue Jan 16, 2018
ghost pushed a commit that referenced this issue Jan 16, 2018
@ghost ghost removed the pending release label Jan 16, 2018
@ghost ghost closed this as completed Jan 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants