Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favorite star not showing #518

Closed
jojosoft opened this issue Jan 6, 2021 · 6 comments
Closed

favorite star not showing #518

jojosoft opened this issue Jan 6, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@jojosoft
Copy link

jojosoft commented Jan 6, 2021

Big thanks to @Rello for actively developing my favorite Nextcloud app! I was happy to dump iTunes and its weird (artificial) restrictions – it's like hosting your own free and privacy-respecting Spotify. However, over the last year, I noticed some things that got a little worse than before (mainly related UI), so I decided to open several smaller issues to address them.

Actual behavior

I like the star feature very much, so it was sad to see that the stars only get (loaded and (?)) displayed for an album if there is currently a track being played back from it. Since the star flag is probably just a boolean for each track, I would very much appreciate it if the star information would always be transferred together with the track name.

Steps to reproduce the behavior

  1. Play any track from a test album
  2. Mark another track of the test album with a star
  3. Play any track from any other album
  4. See how the stars are only displayed for the album that currently has a track playing.

Additional information (optional)

I never used the 5-star-system of iTunes because of the mental load that occurs if I am asked to specify why a song is a 3-star song instead of a 2-star song. It wouldn't be in my collection if I didn't like it. 🤔 However, the binary system in Audio Player made me actually mark the "very good" songs (binge-worthy) with a star! Hopefully this feature will always be there.

Server configuration

Operating system:
Debian 10

Web server:
Apache

Database:
mysql

Nextcloud/ownCloud version: (see /status.php)
19.0.6

Audio Player version: (see /settings/apps)
2.13.1

Are you using external storage? If yes, which one: local/smb/sftp/...
No.

Client configuration

Browser:
Firefox 84.0

@Rello Rello self-assigned this Feb 16, 2021
@Rello Rello added this to the 3.0.1 milestone Feb 16, 2021
@Rello Rello changed the title Preloading of flag marking favorite tracks favorite star not showing Feb 16, 2021
@Rello
Copy link
Owner

Rello commented Feb 16, 2021

solved with the next release

Rello added a commit that referenced this issue Feb 16, 2021
@Rello
Copy link
Owner

Rello commented Feb 17, 2021

@jojosoft
did you upgrade to NC20 already? because the AP-Version for NC19 is not maintained due to double efforts

@jojosoft
Copy link
Author

Good point. I tried to avoid Nextcloud 20 until now because so many things changed, so I'm still on version 19.0.7. I wasn't aware that there are separate versions of Audio Player for different Nextcloud releases. Maybe I should upgrade this month...

@Rello
Copy link
Owner

Rello commented Feb 17, 2021

really? what don´t you like?
I went NC20 immediately with no issues

...they changed some underlaying basics in NC20 which are not backwards compatible.
to push the changes also in the NC19, I would need to rebase changes. but my spare time is a little limited there...

@jojosoft
Copy link
Author

It just seemed like a huge change in direction, and some experienced members of the community seemed to see some problems with that. There were also quite many problem reports in the forum (maybe just my imagination that they were more when Nextcloud 20 was new), so I didn't want to spend time on it until now. From the outside it looks nice, so I might really just try upgrading now and test it a bit! Of course, you don't have to do a rebase for Nextcloud 19, I'm already extremely thankful for your main development efforts on Audio Player! Keep it up! 👍

@Rello
Copy link
Owner

Rello commented Feb 17, 2021

that sounds like a plan.
I also have to put time towards the Analytics app...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants