Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous track button when shuffle is enabled #542

Closed
gsantner opened this issue Jun 8, 2021 · 3 comments
Closed

Previous track button when shuffle is enabled #542

gsantner opened this issue Jun 8, 2021 · 3 comments
Assignees
Milestone

Comments

@gsantner
Copy link

gsantner commented Jun 8, 2021

Describe the bug
When the random is enabled (control state highlighted), the previous track button does not work as expected.
It just jumps to the track one up in the list, but not to the track previously played.

screenrecord2

To Reproduce
Steps to reproduce the behavior:

  1. Open audioplayer addon page
  2. Click random playback toggle to enable random playback
  3. Play a track
  4. Press next track button ~ 5 times
  5. Press previous track button

Expected behavior
That the track is played that actually was before the current one. Not the track that happens to be above in the listview.

Screenshots
See above.

Versions:

  • Nextcloud: Nextcloud 20.0.10
  • Audioplayer 3.1.0
@Rello
Copy link
Owner

Rello commented Jul 10, 2021

Hi,
sorry for the late reply.
nice finding. I will check.

@Rello Rello added this to the 3.2.0 milestone Jul 10, 2021
@Rello Rello self-assigned this Jul 10, 2021
@Rello
Copy link
Owner

Rello commented Aug 16, 2021

Hello,
the reasons is, that the shuffle only shuffles the next upcoming title by calculating a random index number.
I will change the procedure a little.
with a press on the shuffle button, the whole playlist will shuffle visually.
Then all standard coding can apply and everything will work

@Rello Rello changed the title [BUG] Previous track button does not play previous track when random is enabled Previous track button when shuffle is enabled Aug 16, 2021
@Rello Rello added testing and removed in progress labels Aug 16, 2021
@gsantner
Copy link
Author

yeah, I thought it was implemented this way :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants