Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Breeze Dark theme #553

Closed
mfs85 opened this issue Oct 7, 2021 · 6 comments
Closed

Support Breeze Dark theme #553

mfs85 opened this issue Oct 7, 2021 · 6 comments
Assignees
Labels
Milestone

Comments

@mfs85
Copy link

mfs85 commented Oct 7, 2021

Describe the bug

  1. Some items are not clearly visible, when using the Breeze Dark theme.
    Is there something that could be done? At least Menu (Titles, Artist, Playlists, e.g.), progress bar and volume bar is having this issue.

  2. The name of the app is too long and it "overwrites" the names on other apps

To Reproduce
Steps to reproduce the behavior:

  1. Enable Breeze Dark theme
  2. Click on Audio Player
  3. Move the cursor to the Audio Player logo
  4. See error

Expected behavior

  1. To see items clearly when using Breeze Dark theme.
  2. To see app names without overwriting other names

Screenshots
image

Versions:

  • Nextcloud: 21.0.5
  • Audioplayer 3.2.2

Nextcloud log

@mfs85 mfs85 changed the title [BUG] To support Breeze Dark theme and application name [BUG] Oct 7, 2021
@Rello Rello self-assigned this Dec 16, 2021
@Rello Rello added the bug label Dec 16, 2021
@Rello Rello added this to the 3.2.3 milestone Dec 16, 2021
@Rello
Copy link
Owner

Rello commented Dec 16, 2021

Hello,
the issue I see here are the errors in the category dropdrown.
the topic with the overlapping app title is standard Nextcloud behavior. it works this way when app names are longer

@Rello
Copy link
Owner

Rello commented Dec 16, 2021

Hello,
do you have any other theming?
because NC dark theme shows correctly (dropdown) for me.
also the header should be blue

Bildschirmfoto 2021-12-16 um 21 23 11

@mfs85
Copy link
Author

mfs85 commented Dec 17, 2021

No, only this Breeze Dark theme is enabled.
If I deactivate it, I will have light color and header will also changed to blue.

image

@yaroslav4167
Copy link
Contributor

yaroslav4167 commented Dec 27, 2021

i created css styles for fix this. (i use stylus plugin for my firefox) but, you may insert this css code in Custom Styling field.

/*Deploying playlist was hidden under the page*/
.coverrow {
    padding-bottom: 250px;
}

/*** Breeze dark audioplayer fixes ***/
/*In dark mode there is no progress bar */
.theme--dark.theme--breezedark #progressBar,
.volume-slider::-moz-range-track {
    background: #cccccc3d !important;
}

.theme--dark.theme--breezedark .volume-slider::-webkit-slider-progress, 
.theme--dark.theme--breezedark .volume-slider::-moz-range-progress {
    background-color: #0082c9;
    padding: 2px;
    border-radius: 5px;
}

/*Selecting the type of sorting*/
.theme--dark.theme--breezedark #category_selector {
    background-image: none !important;
    margin: 7px 0 !important;
}

@Rello
Copy link
Owner

Rello commented Mar 24, 2022

Hi,

issue is finally solved.
checked in the default theme as well as the dark breeze
thank you for your css suggestion. it helped!

Bildschirmfoto 2022-03-24 um 15 41 28

@Rello Rello changed the title To support Breeze Dark theme and application name [BUG] Support Breeze Dark theme Mar 24, 2022
Rello added a commit that referenced this issue Mar 24, 2022
@Rello Rello modified the milestones: 3.2.3, 3.3.0 Mar 24, 2022
@Rello
Copy link
Owner

Rello commented Mar 29, 2022

3.3.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants