Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to toggle ignore breakpoints #62

Merged
merged 10 commits into from
Nov 10, 2024
Merged

Conversation

RemcoSmitsDev
Copy link
Owner

@RemcoSmitsDev RemcoSmitsDev commented Nov 4, 2024

Screen.Recording.2024-11-10.at.18.05.20.mov

TODO

  • Fix that we don't crash the adapters when sending ignore breakpoints
  • Choose a better color for on/off state
  • Move ignore state to the dap store, so we don't send breakpoints when you dont want to use them
  • Add action for disable breakpoints for all clients/active client

@RemcoSmitsDev RemcoSmitsDev changed the title Add allow users to ignore breakpoints Allow users to toggle ignore breakpoints Nov 4, 2024
@Anthony-Eid
Copy link
Collaborator

Great idea! Maybe instead of using a color to display on/off state you could use a different icon per state. I think that would be better for accessibility and could be clearer than color.

For example, the current ignore could be when it's enabled and a regular circle could be when it's disabled

@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review November 10, 2024 17:18
@RemcoSmitsDev RemcoSmitsDev merged commit c19c860 into debugger Nov 10, 2024
9 checks passed
@RemcoSmitsDev RemcoSmitsDev deleted the ignore-breakpoints branch November 10, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants