Implment Variable List Toggling Function in Collab #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1207,6 +1207,17 @@ impl VariableList { | |||
| .into_any_element() | |||
| } | |||
|
|
|||
| #[cfg(any(test, feature = "test-support"))] | |||
There was a problem hiding this comment.
Can't we make toggle_variable just public? As it's just a proxy now
There was a problem hiding this comment.
Yes we can, but that would mean it's available for any crate to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement variable list toggling while in collab sessions. This is one of the list steps until remote users have the same functionality as local users.
We used to send a SetDebugger message to all clients whenever build entries were called. This led to a lot of redundant information being shared between collab users. Now we only send two messages related to the variable list, a SetDebugger message for the initial scopes and first level of variables, then an AddVariables message whenever a new variable has been toggled.
Not that our bandwidth usage was an issue, but this should save bandwidth during debug sessions. In future iterations, I'm planning on updating the debugger collab DB schema to allow additions to variables without decoding, then encoding data.
I'll also add the OpenEntries to variable list messages again with a setting that allows users to de-sync from the collab sessions’ open variables and look at their own view.
###TODO:
Current State
Screen.Recording.2025-01-14.at.3.24.44.AM.mov