Fix Attachment signatures.

Remora · Apr 4, 2021 · c05608b · c05608b
1 parent 938932b
commit c05608b
Show file tree

Hide file tree

Showing 13 changed files with 22 additions and 38 deletions.
diff --git a/.idea/.idea.Remora.Discord/.idea/indexLayout.xml b/.idea/.idea.Remora.Discord/.idea/indexLayout.xml
diff --git a/.idea/.idea.Remora.Discord/.idea/riderModule.iml b/.idea/.idea.Remora.Discord/.idea/riderModule.iml
diff --git a/Backend/Remora.Discord.API.Abstractions/API/Objects/Messages/IAttachment.cs b/Backend/Remora.Discord.API.Abstractions/API/Objects/Messages/IAttachment.cs
@@ -59,11 +59,11 @@ public interface IAttachment
         /// <summary>
         /// Gets the height of the file (if image).
         /// </summary>
-        int? Height { get; }
+        Optional<int?> Height { get; }
 
         /// <summary>
         /// Gets the width of the file (if image).
         /// </summary>
-        int? Width { get; }
+        Optional<int?> Width { get; }
     }
 }
diff --git a/Backend/Remora.Discord.API.Abstractions/Remora.Discord.API.Abstractions.csproj b/Backend/Remora.Discord.API.Abstractions/Remora.Discord.API.Abstractions.csproj
@@ -5,7 +5,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>12.0.2</Version>
+        <Version>13.0.0</Version>
         <Description>
             $(BaseDescription)
 
@@ -14,8 +14,7 @@
             API.
         </Description>
         <PackageReleaseNotes>
-            Update dependencies.
-            Enable SourceLink.
+            Fix Attachment signature.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Backend/Remora.Discord.API/API/Objects/Messages/Attachment.cs b/Backend/Remora.Discord.API/API/Objects/Messages/Attachment.cs
@@ -37,7 +37,7 @@ public record Attachment
         int Size,
         string Url,
         string ProxyUrl,
-        int? Height,
-        int? Width
+        Optional<int?> Height,
+        Optional<int?> Width
     ) : IAttachment;
 }
diff --git a/Backend/Remora.Discord.API/Remora.Discord.API.csproj b/Backend/Remora.Discord.API/Remora.Discord.API.csproj
@@ -5,16 +5,15 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>12.0.2</Version>
+        <Version>13.0.0</Version>
         <Description>
             $(BaseDescription)
 
             This package contains the default implementations for the abstract API definitions, provided by
             Remora.Discord.API.Abstractions.
         </Description>
         <PackageReleaseNotes>
-            Update dependencies.
-            Enable SourceLink.
+            Fix Attachment signature.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Backend/Remora.Discord.Caching/Remora.Discord.Caching.csproj b/Backend/Remora.Discord.Caching/Remora.Discord.Caching.csproj
@@ -5,15 +5,14 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>1.1.8</Version>
+        <Version>1.1.9</Version>
         <Description>
             $(BaseDescription)
 
             This package contains memory cache functionality for the gateway and REST API.
         </Description>
         <PackageReleaseNotes>
             Update dependencies.
-            Enable SourceLink.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Backend/Remora.Discord.Gateway/Remora.Discord.Gateway.csproj b/Backend/Remora.Discord.Gateway/Remora.Discord.Gateway.csproj
@@ -5,7 +5,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>3.1.9</Version>
+        <Version>3.1.10</Version>
         <Description>
             $(BaseDescription)
 
@@ -14,7 +14,6 @@
         </Description>
         <PackageReleaseNotes>
             Update dependencies.
-            Enable SourceLink.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Backend/Remora.Discord.Rest/Remora.Discord.Rest.csproj b/Backend/Remora.Discord.Rest/Remora.Discord.Rest.csproj
@@ -5,7 +5,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>7.0.4</Version>
+        <Version>7.0.5</Version>
         <Description>
             $(BaseDescription)
 
@@ -14,7 +14,6 @@
         </Description>
         <PackageReleaseNotes>
             Update dependencies.
-            Enable SourceLink.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Remora.Discord.Commands/Remora.Discord.Commands.csproj b/Remora.Discord.Commands/Remora.Discord.Commands.csproj
@@ -5,7 +5,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>3.7.4</Version>
+        <Version>3.7.5</Version>
         <Description>
             $(BaseDescription)
 

diff --git a/Remora.Discord.Hosting/Remora.Discord.Hosting.csproj b/Remora.Discord.Hosting/Remora.Discord.Hosting.csproj
@@ -5,15 +5,14 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>3.0.17</Version>
+        <Version>3.0.18</Version>
         <Description>
             $(BaseDescription)
 
             This package provides a simple implementation of a hosted service.
         </Description>
         <PackageReleaseNotes>
             Update dependencies.
-            Enable SourceLink.
         </PackageReleaseNotes>
     </PropertyGroup>
 

diff --git a/Remora.Discord/Remora.Discord.csproj b/Remora.Discord/Remora.Discord.csproj
@@ -5,7 +5,7 @@
     </PropertyGroup>
 
     <PropertyGroup>
-        <Version>3.0.23</Version>
+        <Version>3.0.24</Version>
         <Description>
             $(BaseDescription)
 

diff --git a/...Remora.Discord.Tests/Samples/Objects/ATTACHMENT/ATTACHMENT-with-missing-width-height.json b/...Remora.Discord.Tests/Samples/Objects/ATTACHMENT/ATTACHMENT-with-missing-width-height.json
@@ -0,0 +1,7 @@
+{
+    "id": "828277590506340435",
+    "filename": "booga.pdf",
+    "size": 1643,
+    "url": "https://fake.url/booga.pdf",
+    "proxy_url": "https://fake.url/booga.pdf"
+}