Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] connect to persistent subscription #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jacekzlowocki
Copy link

This PR contains two changes:

  1. The main one: support for connecting to Persistent Subscriptions with TCP Client
  2. Chore:
    • added missing @types/generic-pool package
    • replaced yarn.lock with package-lock.json - this is done because yarn.lock contains unreachable registry (private RemoteMetering registry?)

@mmuller99 mmuller99 changed the title Feature persistent subscription [Feature] connect to persistent subscription Nov 19, 2020
@mmuller99
Copy link
Member

Hi @jacekzlowocki, thanks for the good looking PR, this is much needed functionality. Apologies for only getting to it now, was on a little vacation. Please see comments below:

"- replaced yarn.lock with package-lock.json - this is done because yarn.lock contains unreachable registry (private RemoteMetering registry?) Sorry about that, if you pull master again, the global registry yarn.lock file should function again"

Would it be possible to add the options and tests for the user to pass in the bufferSize and autoAck params and handle accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants