Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency dependency and compatability #35

Closed
smattox opened this issue Jan 6, 2016 · 2 comments
Closed

Concurrency dependency and compatability #35

smattox opened this issue Jan 6, 2016 · 2 comments

Comments

@smattox
Copy link

smattox commented Jan 6, 2016

This may or may not qualify as an issue for the library as a whole.

The 0.5.0.0 release of NodaMoney on NuGet adds a project dependency upon System.Collections.Concurrent, for the purpose of two ConcurrentDictionaries in the CurrencyRegistry. System.Collections.Concurrent does not appear to be broadly compatible with all PCL profiles, or at least the one that we're dependent upon (78), and so we're unable to use this version. Given the apparently very limited application of System.Collections.Concurrent classes, I wanted to at least float the possibility of removing the dependency in future releases (would locks suffice?).

I know I probably should just utilize a private fork and address this issue on my own, but my organization won't be supporting VS2015/C#6 for a while yet, which means needing to base off months old code before the conversion, and just generally putting up with a whole bunch of maintenance and maintainability headaches. :)

Thanks for reading; great library! I dearly want to make use of it. :)

@RemyDuijkeren
Copy link
Owner

Thanks for the comment!

You normally would change currencies only on the startup of an application, so the Concurrent Dictionary is probably overkill for the CurrencyRegistry.

The focus is to have as less as possible dependencies, so I will check the compatibility with the profiles and improve this in the next version.

RemyDuijkeren pushed a commit that referenced this issue Jan 26, 2016
Update Newtonsoft.Json
@RemyDuijkeren RemyDuijkeren added this to the v0.6.0 milestone Jan 26, 2016
@RemyDuijkeren
Copy link
Owner

The dependency to System.Collections.Concurrent has been removed (replaced by locks), so you should be able to use the next version again.

@RemyDuijkeren RemyDuijkeren removed this from the v0.7.0 milestone Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants