🐞 Panic on ":param" gofiber#405

router.go

@@ -30,30 +30,30 @@ type Route struct {
 }
 
 func (r *Route) match(path, original string) (match bool, values []string) {
+	// Does this route have parameters
+	if len(r.routeParams) > 0 {
+		// Match params
+		if paramPos, match := r.routeParser.getMatch(path, r.use); match {
+			// Get params from the original path
+			return match, r.routeParser.paramsForPos(original, paramPos)
+		}
+	}
 	// Is this route a Middleware?
 	if r.use {
 		// Single slash will match or path prefix
 		if r.root || strings.HasPrefix(path, r.path) {
-			return true, getAllocFreeParams(len(r.routeParser.params))
+			return true, values
 		}
 		// Check for a simple path match
 	} else if len(r.path) == len(path) && r.path == path {
-		return true, getAllocFreeParams(len(r.routeParser.params))
+		return true, values
 	} else if r.root && path == "/" {
 		return true, values
 	}
 	// '*' wildcard matches any path
 	if r.star {
 		return true, []string{utils.TrimLeft(original, '/')}
 	}
-	// Does this route have parameters
-	if len(r.routeParams) > 0 {
-		// Match params
-		if paramPos, match := r.routeParser.getMatch(path, r.use); match {
-			// Get params from the original path
-			return match, r.routeParser.paramsForPos(original, paramPos)
-		}
-	}
 	// No match
 	return false, values
 }

router_test.go

@@ -28,7 +28,7 @@ func Test_Route_Match_SameLength(t *testing.T) {
 
 	body, err := ioutil.ReadAll(resp.Body)
 	utils.AssertEqual(t, nil, err, "app.Test(req)")
-	utils.AssertEqual(t, "", getString(body))
+	utils.AssertEqual(t, ":param", getString(body))
 
 	// with param
 	resp, err = app.Test(httptest.NewRequest(MethodGet, "/test", nil))
@@ -53,7 +53,7 @@ func Test_Route_Match_Star(t *testing.T) {
 
 	body, err := ioutil.ReadAll(resp.Body)
 	utils.AssertEqual(t, nil, err, "app.Test(req)")
-	utils.AssertEqual(t, "", getString(body))
+	utils.AssertEqual(t, "*", getString(body))
 
 	// with param
 	resp, err = app.Test(httptest.NewRequest(MethodGet, "/test", nil))
@@ -121,7 +121,7 @@ func Test_Route_Match_Middleware(t *testing.T) {
 
 	body, err := ioutil.ReadAll(resp.Body)
 	utils.AssertEqual(t, nil, err, "app.Test(req)")
-	utils.AssertEqual(t, "", getString(body))
+	utils.AssertEqual(t, "*", getString(body))
 
 	// with param
 	resp, err = app.Test(httptest.NewRequest(MethodGet, "/foo/bar/fasel", nil))