Display mixin fixes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, LGTM. @Benehiko any issues? |
Benehiko
reviewed
Aug 24, 2021
| return True | ||
| print("Could not set OSD. Camera responded with status:", r_data["value"]) | ||
| print("Could not set OSD. Camera responded with status:", r_data["error"]) |
There was a problem hiding this comment.
Would this then not be the case for every mixin since they all reference the error with the "value" key?
Maybe this was recently added in a camera firmware update?
There was a problem hiding this comment.
Possibly. Haven't dove that far in. Just addressed here since that's where the handling was already.
There was a problem hiding this comment.
Would this then not be the case for every mixin since they all reference the error with the "value" key?
Maybe this was recently added in a camera firmware update?
Yes, it would.
|
Sounds like there's a case for a centralized response handler
|
|
Yeah I'll have to implement one then, will merge this so long! Thank you @stephengolub for the contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was testing some things out and realized that there was an error in the
display.pycode where it wasn't handling the error response keys properly.Also added the ability to toggle the watermark on/off