Skip to content

feat: custom session handler #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: custom session handler #81

merged 1 commit into from
Oct 8, 2024

Conversation

josh-shaw-dev
Copy link
Contributor

Add support for a custom session handler

urllib3 relies on openssl
openSSL 3.3.2 3 Sep 2024 (Library: OpenSSL 3.3.2 3 Sep 2024)

Trying to login into a camera and it fails due to is a older cipher being used

Post Error
 HTTPSConnectionPool(host='url', port=443): Max retries exceeded with url: /cgi-bin/api.cgi?cmd=Login&token=null (Caused by SSLError(SSLError(1, '[SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] ssl/tls alert handshake failure (_ssl.c:1000)')))

Benehiko
Benehiko approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Thank you :)

@Benehiko Benehiko changed the title Add custom session handler feat: custom session handler Oct 8, 2024
@Benehiko Benehiko merged commit b86642c into ReolinkCameraAPI:master Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benehiko Benehiko Benehiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh-shaw-dev @Benehiko