download: use the Playback command instead of Download

[sven337]

On my TrackMix Wifi, both API commands work the same way, but Download is limited to about 800kB/s, while Playback hits about 4MB/s. So, replace the Download command with Playback for get_file.

[Benehiko]

I'm a bit hesitant to just replace something that's already working. Maybe we could create a new file called mixins/playback.py, copy & paste most of the code from mixins/download.py and then inside the api_handler.py do an if with an or to run on both Download and Playback.

I know it's a bit extra work, but it would prevent potentially breaking behavior for others that rely on download.py.

[sven337]

Understood.
I can do what you ask, but I suggest a less verbose alternative. We keep the download mixin and add an optional "method" argument. I can default it to Download if you like. It seems more elegant to me, but let me know what you prefer.

diff --git a/reolinkapi/mixins/download.py b/reolinkapi/mixins/download.py
index 7289cdc..7ffa9e4 100644
--- a/reolinkapi/mixins/download.py
+++ b/reolinkapi/mixins/download.py
@@ -1,18 +1,18 @@
 class DownloadAPIMixin:
     """API calls for downloading video files."""
-    def get_file(self, filename: str, output_path: str) -> bool:
+    def get_file(self, filename: str, output_path: str, method = 'Playback') -> bool:
         """
         Download the selected video file
         :return: response json
         """
         body = [
             {
-                "cmd": "Playback",
+                "cmd": method,
                 "source": filename,
                 "output": filename,
                 "filepath": output_path
             }
         ]
-        resp = self._execute_command('Playback', body)
+        resp = self._execute_command(method, body)
 
         return resp

[Benehiko]

Understood. I can do what you ask, but I suggest a less verbose alternative. We keep the download mixin and add an optional "method" argument. I can default it to Download if you like. It seems more elegant to me, but let me know what you prefer.

diff --git a/reolinkapi/mixins/download.py b/reolinkapi/mixins/download.py
index 7289cdc..7ffa9e4 100644
--- a/reolinkapi/mixins/download.py
+++ b/reolinkapi/mixins/download.py
@@ -1,18 +1,18 @@
 class DownloadAPIMixin:
     """API calls for downloading video files."""
-    def get_file(self, filename: str, output_path: str) -> bool:
+    def get_file(self, filename: str, output_path: str, method = 'Playback') -> bool:
         """
         Download the selected video file
         :return: response json
         """
         body = [
             {
-                "cmd": "Playback",
+                "cmd": method,
                 "source": filename,
                 "output": filename,
                 "filepath": output_path
             }
         ]
-        resp = self._execute_command('Playback', body)
+        resp = self._execute_command(method, body)
 
         return resp

@sven337 SGTM

[sven337]

Done.