Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new props called backgroundColor which sets the backgroundColor of the signature #97

Closed
wants to merge 19 commits into from

Conversation

john1jan
Copy link
Contributor

@john1jan john1jan commented Nov 15, 2017

  • Added three new props for setting strokeColor, minStrokeWidth and maxStrokeWidth
  • Added new props called backgroundColor which takes any color string which supports #RRGGBB #AARRGGBB 'red', 'blue', 'green', 'black', 'white', 'gray', 'cyan', 'magenta', 'yellow', 'lightgray', 'darkgray'
  • Add feature for setting background as transparent. just set backgroundColor="transparent".
  • Removed showBorder as its not required the developer can set border for the container of this component
  • Added a example project as well to use and added demo screenshots as well

This feature is only done in android. I need some one's help to do it on ios.
Tested on android it works great.

Fixed some of the issues with example as it was not compiling in android
@jedt please check it and merge

@john1jan
Copy link
Contributor Author

@jedt @theinventor any update on this PR?

@luskin
Copy link

luskin commented Oct 19, 2018

Can we get this in?

@john1jan
Copy link
Contributor Author

@jedt @theinventor can you check this PR

@zerobytes
Copy link

Hey @john1jan, I'm thinking that if the default background is transparent, there would be no need to haveall those options of colors. Transparent would suffice, for all cases, once you could just set the background of the wrapping component to whatever you need.

@john1jan
Copy link
Contributor Author

i have updated the PR please check

@john1jan
Copy link
Contributor Author

@jedt @theinventor

@jedt
Copy link
Contributor

jedt commented Jan 26, 2021

merged with #216

@jedt jedt closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants