-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grammatical tense needs checking for all instancees of 'run' #15
Comments
should I expect a PR @juliebates ? ;) |
Good question! ;-)
Believe it or not, I don’t think I have ever actually done one, as it happens, so I’m not sure!
I’ll have to look into it when I get in to work in a little bit
…Sent from my iPhone
On Oct 25, 2017, at 8:19 PM, Yaroslav Halchenko <notifications@github.com<mailto:notifications@github.com>> wrote:
should I expect a PR @juliebates<https://github.com/juliebates> ? ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#15 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdPrNvMkUcO7ubsJh0k6byhpXqX-bUUqks5sv9ApgaJpZM4OyqT6>.
|
First pull request, apparently accomplished ;-)
However, as convenient, check to make sure it really worked.
Are there other issues you wanted me to work on, or is that the only one you need?
From: Yaroslav Halchenko <notifications@github.com>
Reply-To: ReproNim/module-reproducible-basics <reply@reply.github.com>
Date: Wednesday, October 25, 2017 at 8:19 PM
To: ReproNim/module-reproducible-basics <module-reproducible-basics@noreply.github.com>
Cc: "Bates, Julianna (Julie)" <Julianna.Bates@umassmed.edu>, Mention <mention@noreply.github.com>
Subject: Re: [ReproNim/module-reproducible-basics] grammatical tense needs checking for all instancees of 'run' (#15)
should I expect a PR @juliebates<https://github.com/juliebates> ? ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#15 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdPrNvMkUcO7ubsJh0k6byhpXqX-bUUqks5sv9ApgaJpZM4OyqT6>.
|
Thanks a lot Julie
Anything you see that needs fixing would be good to know !
JB
On Oct 26, 2017 8:59 PM, "juliebates" <notifications@github.com> wrote:
First pull request, apparently accomplished ;-)
However, as convenient, check to make sure it really worked.
Are there other issues you wanted me to work on, or is that the only one
you need?
From: Yaroslav Halchenko <notifications@github.com>
Reply-To: ReproNim/module-reproducible-basics <reply@reply.github.com>
Date: Wednesday, October 25, 2017 at 8:19 PM
To: ReproNim/module-reproducible-basics <module-reproducible-basics@
noreply.github.com>
Cc: "Bates, Julianna (Julie)" <Julianna.Bates@umassmed.edu>, Mention <
mention@noreply.github.com>
Subject: Re: [ReproNim/module-reproducible-basics] grammatical tense needs
checking for all instancees of 'run' (#15)
should I expect a PR @juliebates<https://github.com/juliebates> ? ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
ReproNim/module-reproducible-basics#15#issuecomment-339512567>, or
mute the thread<https://github.com/notifications/unsubscribe-auth/
AdPrNvMkUcO7ubsJh0k6byhpXqX-bUUqks5sv9ApgaJpZM4OyqT6>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQyaA7ChvUAKU1lEtWiSpLXkI7Co0fRks5swNaJgaJpZM4OyqT6>
.
|
Hi JB
There were a few things in there that I did not fix because I was a little concerned that fixing grammar might alter the meaning inadvertently, or because there were some commands that I thought needed definition when I read through the material, but I am not yet familiar enough with the material to trust that I am the person to make those changes, so I’ll stick with more basic things at least for now!
Also- by the way, I think some of my ‘issues’ included material in the Software Carpentry tutorials, and I assume those are things that should not be changed in the SWC files
I’ll take a look at the other things in the Issues list and see what I can do
Julie
From: Jean-Baptiste Poline <notifications@github.com>
Reply-To: ReproNim/module-reproducible-basics <reply@reply.github.com>
Date: Thursday, October 26, 2017 at 3:03 PM
To: ReproNim/module-reproducible-basics <module-reproducible-basics@noreply.github.com>
Cc: "Bates, Julianna (Julie)" <Julianna.Bates@umassmed.edu>, Mention <mention@noreply.github.com>
Subject: Re: [ReproNim/module-reproducible-basics] grammatical tense needs checking for all instancees of 'run' (#15)
Thanks a lot Julie
Anything you see that needs fixing would be good to know !
JB
On Oct 26, 2017 8:59 PM, "juliebates" <notifications@github.com> wrote:
First pull request, apparently accomplished ;-)
However, as convenient, check to make sure it really worked.
Are there other issues you wanted me to work on, or is that the only one
you need?
From: Yaroslav Halchenko <notifications@github.com>
Reply-To: ReproNim/module-reproducible-basics <reply@reply.github.com>
Date: Wednesday, October 25, 2017 at 8:19 PM
To: ReproNim/module-reproducible-basics <module-reproducible-basics@
noreply.github.com>
Cc: "Bates, Julianna (Julie)" <Julianna.Bates@umassmed.edu>, Mention <
mention@noreply.github.com>
Subject: Re: [ReproNim/module-reproducible-basics] grammatical tense needs
checking for all instancees of 'run' (#15)
should I expect a PR @juliebates<https://github.com/juliebates> ? ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
ReproNim/module-reproducible-basics#15#issuecomment-339512567>, or
mute the thread<https://github.com/notifications/unsubscribe-auth/
AdPrNvMkUcO7ubsJh0k6byhpXqX-bUUqks5sv9ApgaJpZM4OyqT6>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQyaA7ChvUAKU1lEtWiSpLXkI7Co0fRks5swNaJgaJpZM4OyqT6>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#15 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdPrNqwS1gY0SVxL3AfL3AhXCPrQKH5Nks5swNeagaJpZM4OyqT6>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
'ran' should often be 'was run' or 'has been run' -- this can be checked in later version, just a general comment that the tenses need to be checked throughout for this particular verb
The text was updated successfully, but these errors were encountered: