do not install sphinx 6.x #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pydata theme we are using seems to be incompatible with sphinx 6.x which was released recently. We prevent this version from being installed for the time being. The error produced with sphinx 6.x is below and is related to pydata/pydata-sphinx-theme#1094. This has been fixed in pydata-sphinx-theme but has not been released yet. The fix should be part of the next release 0.13. ``` Theme error: An error happened in rendering the page api. Reason: UndefinedError("'logo' is undefined") make: *** [Makefile:20: html] Error 2 ```
Codecov ReportBase: 88.77% // Head: 88.77% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 11 11
Lines 1033 1033
=======================================
Hits 917 917
Misses 116 116 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pydata theme we are using seems to be incompatible with sphinx 6.x which was released recently. This broke the docs build. We prevent this version from being installed for the time being. The error produced with sphinx 6.x is below and is related to
pydata/pydata-sphinx-theme#1094.
This has been fixed in pydata-sphinx-theme but has not been released yet. The fix should be part of the next release 0.13.
i do not know whether this will resolve #503