Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install sphinx 6.x #505

Merged
merged 1 commit into from
Feb 3, 2023
Merged

do not install sphinx 6.x #505

merged 1 commit into from
Feb 3, 2023

Conversation

kaczmarj
Copy link
Collaborator

The pydata theme we are using seems to be incompatible with sphinx 6.x which was released recently. This broke the docs build. We prevent this version from being installed for the time being. The error produced with sphinx 6.x is below and is related to
pydata/pydata-sphinx-theme#1094.

This has been fixed in pydata-sphinx-theme but has not been released yet. The fix should be part of the next release 0.13.

Theme error:
An error happened in rendering the page api.
Reason: UndefinedError("'logo' is undefined")
make: *** [Makefile:20: html] Error 2

i do not know whether this will resolve #503

The pydata theme we are using seems to be incompatible with sphinx 6.x
which was released recently. We prevent this version from being
installed for the time being. The error produced with sphinx 6.x is
below and is related to
pydata/pydata-sphinx-theme#1094.

This has been fixed in pydata-sphinx-theme but has not been released
yet. The fix should be part of the next release 0.13.

```
Theme error:
An error happened in rendering the page api.
Reason: UndefinedError("'logo' is undefined")
make: *** [Makefile:20: html] Error 2
```
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 88.77% // Head: 88.77% // No change to project coverage 👍

Coverage data is based on head (ce889be) compared to base (4e902ec).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files          11       11           
  Lines        1033     1033           
=======================================
  Hits          917      917           
  Misses        116      116           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satra satra merged commit d671f28 into master Feb 3, 2023
@kaczmarj kaczmarj deleted the fix/docs-sphinx6 branch February 15, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: repronim.org/neurodocker not found
2 participants