Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale docker-py dependency #387

Closed
kyleam opened this issue Feb 28, 2019 · 0 comments · Fixed by #481
Closed

Stale docker-py dependency #387

kyleam opened this issue Feb 28, 2019 · 0 comments · Fixed by #481

Comments

@kyleam
Copy link
Contributor

kyleam commented Feb 28, 2019 •
edited
Loading

It looks like we're relying on a pretty old and unsupported version of docker-py.

reproman/setup.py

Line 71 in c6dc43f

'docker-py>=0.3.2',

The docker module hasn't been released under the name docker-py since 2016. Since then, there hav been many releases under the name "docker" (no "-py"). I haven't looked into this deeply, but simply changing 'docker-py>=0.3.2' to 'docker' won't work without further adjustments. (There first error I ran into was "module 'docker' has no attribute 'Client' [docker_container.py:connect:100]".) Also, it seems like we'd have to make adjustments in order to work with dockerpty.
kyleam added a commit to kyleam/niceman that referenced this issue Nov 5, 2019
@kyleam
MNT: Unpin docker-py
310795b 
The docker module hasn't been released under the name "docker-py"
since 2016 [0] and has seen many releases under the name "docker" [1].
So we've effectively been pinning the release to version 1.10.6 even
though the current version is 4.1.0.

To update to latest version, it looks like we can get by with
substituting APIClient for Client.  Set the new floor to version
2.3.0, the release that introduced APIClient.

Closes ReproNim#387.

[0]: https://pypi.org/project/docker-py
[1]: https://pypi.org/project/docker
@kyleam kyleam mentioned this issue Nov 5, 2019
Merged
kyleam added a commit to kyleam/niceman that referenced this issue Nov 5, 2019
@kyleam
MNT: Unpin docker-py
5bfa011 
The docker module hasn't been released under the name "docker-py"
since 2016 [0] and has seen many releases under the name "docker" [1].
So we've effectively been pinning the release to version 1.10.6 even
though the current version is 4.1.0.

To update to latest version, it looks like we can get by with
substituting APIClient for Client.  Set the new floor to version
2.3.0, the release that introduced APIClient.

Closes ReproNim#387.

[0]: https://pypi.org/project/docker-py
[1]: https://pypi.org/project/docker
@kyleam kyleam closed this as completed in 8ab2d0e Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT: Unpin docker-py kyleam/niceman
1 participant
@kyleam