Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion tools #3

Open
Remi-Gau opened this issue Jul 2, 2020 · 7 comments
Open

conversion tools #3

Remi-Gau opened this issue Jul 2, 2020 · 7 comments

Comments

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jul 2, 2020

hey @satra

in case some of the ugly python code I have been creating to create the cobidas schema is useful, feel free to reuse it to recycle and improve.

it is here: https://github.com/Remi-Gau/COBIDAS_chckls/tree/master/conversion_scripts

@satra
Copy link
Contributor

satra commented Jul 2, 2020

thanks @remi - this should be helpful for the python version. i spoke to @sanuann yesterday and she plans to update the javascript converter as that may still be useful in some javascript tabular ui.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jul 2, 2020

I also think that having some "tools" in both languages might definitely help with adoption. 😄

@satra
Copy link
Contributor

satra commented Jul 18, 2020

@Remi-Gau - when you get a chance could you please send a PR adding your conversion script, so that we know you contributed it. i can then refactor it to do the conversion from google spreadsheets/redcap csv's.

satra pushed a commit that referenced this issue Mar 16, 2021
fix and refactor audio, video and image properties
@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jun 4, 2021

@satra
Quick question: what would be a sensible "testing" strategy for the code that should help with schema creation?

Would the idea be to have a sample of test.jsonld files that we check the output of the test against?

@satra
Copy link
Contributor

satra commented Jun 4, 2021

Yes. Having a set of files/folders that can be produced by the generation code would be a set of tests.

To be comprehensive, we would want a set of crud (create, read, update, delete) tests

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Jun 4, 2021

will have to get familiar with crud then because the only crud I knew till now was that of Paul Mheel

OK so apparently this is completely different from setup and teardown within a test, these are the different types of behavior we would like to create test for, is that correct?

@satra
Copy link
Contributor

satra commented Jun 4, 2021

these are the different types of behavior we would like to create test for, is that correct?

yes, if you think of the reproschema-py as kind of an API and reproschema as a DB, then the library needs tests for its operations, which are referred to as CRUD. these would be separate tests, but they may have many variants as well. it is a good lens to think through about the use cases and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants