Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding id check to the validation #68

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

djarecka
Copy link
Member

@satra - I understand that response id also should be the same as name?

perhaps also wasAttributedFrom should be changes?

@satra
Copy link
Contributor

satra commented Jul 12, 2024

only protocol, activity, and item as these are accessed via the web, hence the name needs to match the id in the jsonld file, not response or any other objects

@djarecka
Copy link
Member Author

ok, changed it.

had to fix id names in some schema in the test/data

@yibeichan
Copy link
Contributor

this PR is related to this issue #43, correct? is this one good to be merged?

@djarecka djarecka merged commit aecab71 into ReproNim:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants