Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Linkml #451

Closed
wants to merge 38 commits into from
Closed

[wip] Linkml #451

wants to merge 38 commits into from

Conversation

djarecka
Copy link
Member

@djarecka djarecka commented Jul 20, 2023

creating a pr from the linkml branch I showed in June

this is how the linkml was created:

@djarecka
Copy link
Member Author

@satra - @sooyounga and I met today and we tried to recall what else has to be done for this PR, and want to double check with you. In order to finish this, we should:

  • check if the pydantic version of the schema is a proper schema, and if you are able to initialize all the objects (I've started checkin g this and e.g., I had to rename Field to Item)
  • check if we can reuse linkml types (I believe I change multiple types to linkml ones in my last commit, but perhaps there is something more that we could change)
  • create functions that reads items from the reproschema-library (e.g. this one) and creates instances of the classes defined in the pydantic file (likely some additional fixes to the model might be needed) @satra - should this be part of this repository or reproschema-py?

Anything else should be done or tested in order to complete this PR?

@satra
Copy link
Contributor

satra commented Sep 28, 2023

the pydantic code and any additional functions should be part of the reproschema-py repo.

for this repo, a generated jsonld context and shacl validation should be the same functionally to what exists.

for any change, an action may need to pull in reproschema-py, augment it with changed pydantic code, and then test with that change, and also submit that change as a PR to the reproschema-py repo.

@djarecka djarecka closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants