feat: add native USDC tokens and update stablecoin listings across chains #10
Conversation
WalkthroughThe changes update the Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to data updates in a JSON file and do not affect control flow or logic. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tokens/token-list.json (2)
7611-7621: Review: Bridged USDC renamed to USDC.e on Polygon
You updated the symbol toUSDCeand clarified the name. However, theidremainsUSDC-matic, which may cause confusion. Consider renaming it toUSDCe-maticto match the symbol and improve discoverability.
7755-7764: Review: Bridged USDC entry on Optimism
The bridged USDC (USDCe) entry on Optimism correctly reflects theUSDC.enaming. To maintain parity with the Polygon changes, consider updating theidfield toUSDCe-optimismso it aligns with the symbol.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tokens/token-list.json(4 hunks)
🔇 Additional comments (8)
tokens/token-list.json (8)
7601-7609: Review: Native USDC entry on Polygon
The new native USDC entry (USDCn-matic) is structurally correct. Please verify the contract address0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359against official Polygon documentation or PolygonScan. Additionally, consider aligning theidnaming convention (e.g.,USDC-maticorUSDC-native-matic) with other networks for consistency.
7765-7775: Review: Native USDC entry on Optimism
The native USDC addition for Optimism (USDCn-optimism) is properly formatted. Please verify the contract address0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85against official sources. Also, decide if theidshould beUSDC-optimism(dropping then) for naming consistency with other networks’ native tokens.
7930-7940: Review: Native USDC entry on Arbitrum One
TheUSDC-arbitrum-oneentry is consistent with other native token patterns. Ensure that0xaf88d065e77c8cC2239327C5EDb3A432268e5831matches the official Arbitrum One deployment.
7941-7951: Approve: USDT entry on Arbitrum One
The addition of USDT (USD Tether) on Arbitrum One is correct, with properdecimalsand valid address0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9.
7952-7962: Approve: DAI entry on Arbitrum One
The DAI token entry for Arbitrum One is accurate. Theaddress0xDA10009cBd5D07dd0CeCc66161FC93D7c9000da1anddecimalsare correct.
8085-8094: Review: Native USDC entry on Base
The USDC addition for Base appears correct. Please confirm the contract address0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913and consider if theidneeds a suffix (e.g.,USDC-base) to avoid clashes with other network entries.
8095-8105: Approve: DAI entry on Base
The DAI (Dai Stablecoin) entry on Base is well-formed, with correctdecimalsand address0x50c5725949A6F0c72E6C4a641F24049A917DB0Cb.
8106-8116: Approve: USDT entry on Base
The USDT addition for Base (USD Tether) is correct, with the rightdecimalsand address0xfde4C96c8593536E31F229EA8f37b2ADa2699bb2.
There was a problem hiding this comment.
Please add a Considerations section to the description explaining why these values were chosen, especially IDs. 🙏
Include:
- Link to page explaining USDC (Native) vs USDC.e (Bridged)
- Explain that we don't want to change IDs but we're okay adjusting symbols and names. So existing Bridged USDC will keep IDs like USDC and Native USDC gets IDs like USDCn (notice the
nsuffix). - Mention intention to maintain backward compatibility with existing requests and consistency with Request Finance's currency API.
aimensahnoun
deleted the
9-fix-usdce-bridged-in-token-list-and-add-usdc-native
branch
Changes
Added native USDC tokens for:
0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359)0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85)0xaf88d065e77c8cC2239327C5EDb3A432268e5831)Renamed existing bridged USDC tokens to USDC.e for clarity:
Added new stablecoin tokens:
0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9)0xDA10009cBd5D07dd0CeCc66161FC93D7c9000da1)0x50c5725949A6F0c72E6C4a641F24049A917DB0Cb)0xfde4C96c8593536E31F229EA8f37b2ADa2699bb2)Details:
Some of the tokens existing in the list such as
USDC-maticwasUSDC.einstead of nativeUSDC, this PR aims to clarify that. For more details about differences of the two tokens, you can read this articleUSDC-maticwill still be the ID ofUSDC.eto ensure the backwards compatibility of existing requests, since the token ID is the main identifier of used currency in a request. The nativeUSDCis now added to the list underUSDCn-matic, this is the case of all chains that already had a USDC.e.Summary
This PR updates the token list to properly distinguish between native and bridged USDC tokens across different chains, while also adding support for additional stablecoins (DAI, USDT) on Arbitrum One and Base networks. This improves clarity for users and expands the available stablecoin options on supported networks.
Summary by CodeRabbit