chore: update to near-api-js 4.0.2 #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MantisClone
commented
Jun 14, 2024
| @@ -44,6 +44,7 @@ export const isNearAccountSolvent = ( | |||
| const fungibleContract = new Contract(nearWalletConnection.account(), token.value, { | |||
| changeMethods: [], | |||
| viewMethods: ['ft_balance_of'], | |||
| useLocalViewExecution: true, | |||
There was a problem hiding this comment.
This parameter was added in near/near-api-js#1172. I don't fully understand it, but I don't think it will break anything. It might make view functions to the same blockId more efficient.
MantisClone
requested review from
alexandre-abrioux,
leoslr,
yomarion,
aimensahnoun and
sstefdev
alexandre-abrioux
approved these changes
Jun 17, 2024
sstefdev
approved these changes
Jun 17, 2024
aimensahnoun
approved these changes
Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1390
Description of the changes
Motivation
For near/near-api-js#1194 - to avoid the need to polyfill
httpandhttpsin React Native environments. I'll be able to test it in https://github.com/RequestNetwork/expo-starter-request-network as soon as the-nextversion is released to NPM.Test
Using
npm linkI verified that this does indeed eliminate the need to polyfillhttpandhttps👍