fix: link script to use cd instead of pushd/popd

[MantisClone]

Description of the changes

fix: link script to use cd instead of pushd/popd

Problem

pushd/popd not found.

Details

mantisclone@mantisclone-Inspiron-7620:~/projects/requestNetwork$ yarn run link:all
yarn run v1.22.19
$ for d in packages/*; do pushd $d; yarn link; popd; done
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
/bin/sh: 1: pushd: not found
warning There's already a package called "@requestnetwork/request-network-monorepo" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.
/bin/sh: 1: popd: not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Summary by CodeRabbit

• Improvements
  • Simplified the linking and unlinking commands for packages, enhancing readability and maintainability of the scripts.
  • Maintained the same functionality for linking and unlinking all packages in the packages directory.

[coderabbitai]

Walkthrough

The changes to the package.json file simplify the scripts for linking and unlinking packages within a directory. The previous implementation used pushd and popd for directory navigation, which has been replaced with the simpler cd command, enhancing readability and maintainability. The core functionality remains the same, linking and unlinking all packages within the packages directory, but the commands are now more straightforward.

Changes

File	Change Summary
package.json	Updated the "link:all" and "unlink:all" scripts to use cd instead of pushd/popd for directory navigation, improving readability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Terminal
    participant PackageManager

    User->>Terminal: Run link:all
    Terminal->>PackageManager: cd to each package
    PackageManager-->>Terminal: Link package
    Terminal->>PackageManager: cd back
    User->>Terminal: Run unlink:all
    Terminal->>PackageManager: cd to each package
    PackageManager-->>Terminal: Unlink package
    Terminal->>PackageManager: cd back

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 35e1281 and e745a71.

Files selected for processing (1)

• package.json (1 hunks)

Additional comments not posted (2)

package.json (2)

32-32: LGTM! Verify the functionality of the updated link:all script.

The change to use cd and cd - instead of pushd and popd should resolve the issue with the commands not being found. The new implementation is simpler and more straightforward.

However, please verify that the updated script works as expected in your environment.

---

33-33: LGTM! Verify the functionality of the updated unlink:all script.

The change to use cd and cd - instead of pushd and popd should resolve the issue with the commands not being found. The new implementation is simpler and more straightforward.

However, please verify that the updated script works as expected in your environment.