Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: transfer contract ownership base #1530

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

leoslr
Copy link
Contributor

@leoslr leoslr commented Dec 13, 2024

Description of the changes

Transfer all of the contracts ownership to a Safe Admin on base chain.
Signer settings have been set up in the same way as on the other chains.

Summary by CodeRabbit

  • New Features
    • Added support for the base network in the deployment configuration of the safeAdminArtifact.
    • Included new deployment entry with address and creation block number for the base network.

Copy link
Contributor

coderabbitai bot commented Dec 13, 2024

Walkthrough

The changes in this pull request introduce a new deployment entry for the base network in the safeAdminArtifact configuration. Specifically, a structure detailing the address and creation block number for the base network has been added under version 0.1.0 of the deployment object. This update allows the safeAdminArtifact to accommodate the base network alongside several other previously supported networks.

Changes

File Path Change Summary
packages/smart-contracts/src/lib/artifacts/Admin/index.ts Added deployment entry for base network in safeAdminArtifact with address and creation block number.

Possibly related PRs

  • chore: Single Request Proxy deployment to mainnets #1486: The changes in this PR include the addition of deployment configurations for the base network in the singleRequestProxyFactoryArtifact, which is directly related to the addition of the base network entry in the safeAdminArtifact in the main PR.

Suggested reviewers

  • alexandre-abrioux
  • kevindavee
  • MantisClone
  • rodrigopavezi

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1873e14 and ef91ecc.

📒 Files selected for processing (1)
  • packages/smart-contracts/src/lib/artifacts/Admin/index.ts (1 hunks)
🔇 Additional comments (2)
packages/smart-contracts/src/lib/artifacts/Admin/index.ts (2)

50-53: LGTM! Configuration follows established pattern

The Base network configuration follows the same structure as other networks, maintaining consistency in the artifact definition.


50-53: Verify Safe Admin setup on Base

Please ensure:

  1. The Safe Admin contract at 0xf735afF55745e00D85F30AFB01E1c042D0755628 is properly configured on Base
  2. The ownership transfer to this Safe Admin has been executed correctly

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leoslr leoslr merged commit 9b89952 into master Dec 16, 2024
10 checks passed
@leoslr leoslr deleted the chore/transfer-ownership-base branch December 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants