fix(request-client): remove useLocalEthereumBroadcast from tests #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benjlevesque,
kevindavee and
yomarion
kevindavee
approved these changes
Oct 7, 2022
benjlevesque
approved these changes
Oct 7, 2022
Contributor
benjlevesque
left a comment
benjlevesque
left a comment
There was a problem hiding this comment.
nice catch... why didn't it fail the CI?
alexandre-abrioux
force-pushed
the
fixup/payment-network-factory
branch
from
7543c75 to
a60677d
Compare
| // Creates a local or default provider | ||
| this.provider = web3 | ||
| ? new ethers.providers.Web3Provider(web3.currentProvider) | ||
| ? new ethers.providers.Web3Provider(web3) |
Contributor
Author
There was a problem hiding this comment.
currentProvider is not used anymore, see https://docs.metamask.io/guide/provider-migration.html#window-ethereum-api-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This is a fixup for #930