feat: add receipt export and viewing on request scan #142
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| export { debounce } from "./debounce"; | ||
| export { formatAddress } from "./formatAddress"; | ||
| export { publicClientToProvider, walletClientToSigner } from "./wallet-utils"; | ||
| export { capitalize } from "./capitalize"; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ | |
| export let invoiceNumber: string | undefined; | ||
| export let feeAddress: string; | ||
| export let feeAmountInUSD: number; | ||
| export let createdRequest: any; | ||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider using a more specific type for The use of Here's a suggested improvement: // Assuming there's a Request type defined elsewhere
import type { Request } from '../types';
// The created request object after successful payment processing
export let createdRequest: Request | null = null;This change provides type safety and sets a default value, making the code more robust and self-documenting. |
||
| const COUNTDOWN_INTERVAL = 30; | ||
|
|
@@ -275,6 +276,8 @@ | |
| persistRequest, | ||
| }); | ||
|
|
||
| createdRequest = request; | ||
|
|
||
|
Comment on lines
+279
to
+280
Contributor
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM! Consider adding type assertion for The assignment of the To further improve type safety and error handling, consider adding a type assertion and a null check: if (request) {
createdRequest = request as Request; // Assuming Request is the correct type
} else {
console.warn('Request object is null or undefined after payment processing');
}This change ensures that |
||
| if (onPaymentSuccess) { | ||
| onPaymentSuccess(request); | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,8 @@ | |
| export let invoiceNumber: string | undefined = undefined; | ||
| export let feeAddress: string = ethers.constants.AddressZero; | ||
| export let feeAmountInUSD: number = 0; | ||
| export let enablePdfReceipt: boolean = true; | ||
| export let enableRequestScanLink: boolean = true; | ||
|
Comment on lines
+42
to
+43
Contributor
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM! Consider adding JSDoc comments. The new exported properties Consider adding JSDoc comments to describe these new properties and their purpose. For example: /** Enable the option to generate and download a PDF receipt. Default is true. */
export let enablePdfReceipt: boolean = true;
/** Enable the option to view the request on RequestScan. Default is true. */
export let enableRequestScanLink: boolean = true; |
||
| // State | ||
| let web3Modal: Web3Modal | null = null; | ||
|
|
@@ -47,7 +49,7 @@ | |
| let selectedCurrency: Currency | null = null; | ||
| let connectionCheckInterval: ReturnType<typeof setInterval> | null = null; | ||
| let currentPaymentStep: PaymentStep = "currency"; | ||
| let createdRequest: any; | ||
|
Contributor
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM! Consider adding a type annotation. The new Consider adding a type annotation to let createdRequest: PaymentRequest | null = null;Replace |
||
| let scrollPosition = 0; | ||
| // Effects | ||
|
|
@@ -246,12 +248,18 @@ | |
| onPaymentError={onError} | ||
| bind:currentPaymentStep | ||
| bind:isConnected | ||
| bind:createdRequest | ||
| {sellerInfo} | ||
| buyerInfo={currentBuyerInfo} | ||
| {invoiceNumber} | ||
| /> | ||
| {:else} | ||
| <PaymentComplete | ||
| {createdRequest} | ||
| {enablePdfReceipt} | ||
| {enableRequestScanLink} | ||
| sellerLogo={sellerInfo.logo} | ||
| /> | ||
| {/if} | ||
| </Modal> | ||
| </section> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,8 @@ export interface PaymentWidgetProps { | |
| invoiceNumber?: string; | ||
| feeAddress?: string; | ||
| feeAmountInUSD?: number; | ||
| enablePdfReceipt?: boolean; | ||
| enableRequestScanLink?: boolean; | ||
|
Comment on lines
+26
to
+27
Contributor
There was a problem hiding this comment. 🧹 Nitpick (assertive) LGTM! Consider updating documentation. The new properties Consider updating the JSDoc comment for the * @example
* <PaymentWidget
* // ... other props ...
* enablePdfReceipt={true}
* enableRequestScanLink={true}
* /> |
||
| } | ||
|
|
||
| /** | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -276,7 +276,7 @@ export const handleRequestPayment = async ({ | |
| skipPersistence: true, | ||
| }); | ||
|
|
||
| let inMemoryRequest = | ||
| await inMemoryRequestNetwork.createRequest(requestParameters); | ||
|
|
||
| const signer = await ethersProvider!.getSigner(); | ||
|
|
@@ -328,6 +328,14 @@ export const handleRequestPayment = async ({ | |
| await persistingRequestNetwork.persistRequest(inMemoryRequest); | ||
| } | ||
|
|
||
| if (inMemoryRequest?.inMemoryInfo?.requestData) { | ||
| inMemoryRequest.inMemoryInfo.requestData = { | ||
| ...inMemoryRequest.inMemoryInfo.requestData, | ||
| payer: requestParameters.requestInfo.payer, | ||
| payee: requestParameters.requestInfo.payee, | ||
| }; | ||
| } | ||
|
|
||
| return inMemoryRequest; | ||
| }; | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! Consider consolidating utility imports.
The refactoring to use shared utilities for
exportToPDFandgetCurrencyFromManageris a good practice for improving code reusability.Consider moving
walletClientToSignerto the shared utils as well if it's used in multiple places across the project. This would further improve consistency and maintainability.Also applies to: 30-30