-
Notifications
You must be signed in to change notification settings - Fork 9
chore: update currency #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request involves updates to several packages within the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (8)
🔇 Additional comments (2)package.json (2)
Since this is a monorepo setup, we should ensure all packages are using the same version of @requestnetwork/currency to avoid potential conflicts. ✅ Verification successfulThe previous command might have failed because the directories 'packages/' and 'shared/' don't exist. Let's do a broader search to understand the repository structure and find any references to this dependency. All packages are using the same currency version 0.21.0 Based on the search results, all references to @requestnetwork/currency in the repository are consistently using version 0.21.0. This is confirmed by:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check currency dependency version across all packages
# Find and check all package.json files in workspace packages
fd package.json packages/ shared/ -x grep -H "@requestnetwork/currency"
Length of output: 71 Script: #!/bin/bash
# Let's try a broader search to find all package.json files and their content
fd package.json -x cat {} | grep -B5 -A5 "@requestnetwork/currency" || true
# Also search for any direct references to this package in the codebase
rg "@requestnetwork/currency" || true
Length of output: 2092
The update spans two minor versions. While this should be backward compatible according to semver, it's important to verify the changes. ✅ Verification successfulCurrency package update appears safe to proceed The analysis shows:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for breaking changes in the currency package
# Check if there's a CHANGELOG.md in the repository
fd -g "CHANGELOG.md" -x cat {} | grep -A 10 "0.2[01]\.0"
# Check for type-related changes in .d.ts files
rg -t ts "export|interface|type" --glob "**/@requestnetwork/currency@0.21.0/**/*.d.ts"
Length of output: 781 Script: #!/bin/bash
# Let's try a different approach to find dependency information and version changes
# Check all package.json files for currency dependency
rg -A 1 "@requestnetwork/currency" --glob "package.json"
# Check if there are any type-related files that import from currency package
rg -l "from.*@requestnetwork/currency" --type ts
# Look for type-related imports or usage
rg "import.*@requestnetwork/currency" --type ts -A 2
Length of output: 2322 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Problem
Missed to upgrade currency to latest so I was having issue with types
Change
Upgrade currency to 0.21.0
Summary by CodeRabbit
New Features
@requestnetwork/currencypackage to version 0.21.0 across multiple components.Version Updates
@requestnetwork/add-stakeholder: 0.1.1 → 0.1.2@requestnetwork/create-invoice-form: 0.11.7 → 0.11.8@requestnetwork/invoice-dashboard: 0.11.4 → 0.11.5@requestnetwork/payment-widget: 0.3.4 → 0.3.5