-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update license headers in source files #607
Comments
http://stackoverflow.com/a/3487102/1054728 says: You should add the current year to the list of copyright years if and only if you make a copyrightable change to the file. Trivial patches like adding null pointer checks and the like are generally considered to not be copyrightable So a significant change is something that involves creative thought. Renaming variables or adding trivial comments is not considered copyrightable. http://stackoverflow.com/a/20911485/1054728 says: Google doesn't update their copyright dates because they don't care whether some page they started in 1999 and updated this year falls into the public domain in 2094 or 2109. And if they don't, why should you? I tend to agree with this. Don't bother updating copyright years.
I think including the standard short GPLv3 header is fine:
|
This wording seems good.
Okay, so regarding copyright updating the years isn't necessary. However, I think it would be at least nice if the years were updated, because then you can quickly see who did when (approximately) contribute to that file. This is also what is written in this article:
Of course using One more thing: The copyright lines should be ordered by the year of each contributor's first contribution, no? So in many files it would be first Justin, then me. |
It is ok to update years. It is also ok not to do so, because git commit logs should be enough should a copyright dispute arise. It is important to list all contributors for each file. However if you want trackability/attribution for specific commits/lines in the file, then git logs are the way to go. So, no big deal if the years are inexact/lagging behind real ones. |
Alright, I think I won't update the years. So we can now step over to actually apply what we've decided. I'd do that when #489 is merged. |
There has been some discussion – #578 – about the copyright lines in the source files' headers. Currently it's only me and justin in there, and the years do not represent in which years that specific file has been worked on.
This issue therefore includes:
Some thoughts about the copyright lines:
The text was updated successfully, but these errors were encountered: